Sync eng/common directory with azure-sdk-tools for PR 12350 #44321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory from azure-sdk-tools repository (PR #12350), introducing two key infrastructure changes: adding the SSS3PT_ prefix to stress test cluster resource group names for compliance purposes, and implementing validation logic to prevent deployment failures when local addon configuration changes are detected.
Key Changes:
- Updated stress test cluster resource group names with
SSS3PT_prefix across all environments (pg, prod, storage) - Added pre-deployment validation to detect uncommitted values.yaml changes and require explicit LocalAddonsPath parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Added SSS3PT_ prefix to cluster group names for pg, prod, and storage environments to comply with TME tenant naming conventions |
| eng/common/scripts/stress-testing/deploy-stress-tests.ps1 | Added validation logic to detect local changes to stress-test-addons values.yaml and fail early with helpful error message if LocalAddonsPath is not specified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12350 See eng/common workflow