Skip to content

Conversation

@dargilco
Copy link
Member

@dargilco dargilco commented Dec 8, 2025

  • Add async tests
  • Add test recordings
  • Disable a few sample test per conversation with Howie, until we find a better solution for those failing tests.

Unrelated:

  • Fix 'black' formatting in one of the samples

@dargilco dargilco changed the title Add test recordings to file search tool (and more) Add async test for file search tool and add test recordings Dec 8, 2025
@dargilco dargilco marked this pull request as ready for review December 8, 2025 17:50
Copilot AI review requested due to automatic review settings December 8, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds async test coverage for the file search tool functionality and enables test recording for these tests. The PR also includes an unrelated black formatting fix in an evaluation sample file.

Key changes:

  • Added async versions of file search tests (both streaming and non-streaming)
  • Enabled test recording by replacing pytest.mark.skipif with @recorded_by_proxy decorators
  • Refactored sync tests to use helper method _validate_agent_version for consistency
  • Applied black formatting to evaluation sample file

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_file_search_stream_async.py New async test file for streaming file search functionality
sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_file_search_async.py New async test file with two test methods: basic file search and multi-turn conversation
sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_file_search_stream.py Enabled test recording, refactored to use _validate_agent_version helper, removed pytest import
sdk/ai/azure-ai-projects/tests/agents/tools/test_agent_file_search.py Enabled test recording for all three test methods, refactored validation code to use helper method
sdk/ai/azure-ai-projects/samples/evaluations/sample_evaluations_score_model_grader_with_image.py Applied black formatting: converted single quotes to double quotes, adjusted line breaks for consistency
sdk/ai/azure-ai-projects/assets.json Updated test recording tag to reference new recordings

@dargilco dargilco merged commit 2afb5e2 into main Dec 9, 2025
20 checks passed
@dargilco dargilco deleted the dargilco/more-test-recordings-for-agent-tools branch December 9, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants