-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[provisioning] Reintroduce GetResourceId and GetExtensionResourceId APIs in 1.5.0-beta.1 #54396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
ArcturusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please run <RepoRoot>/eng/scripts/Export-API.ps1 provisioning to refresh the API files.
…esourceId Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Done! The API files have been refreshed. The two reintroduced methods ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reintroduces BicepFunction.GetResourceId and BicepFunction.GetExtensionResourceId APIs that were temporarily removed in version 1.4.0 pending API review. These methods provide C# access to corresponding Bicep built-in functions for resource ID resolution.
Key Changes:
- Uncommented
GetResourceId()andGetExtensionResourceId()methods in BicepFunction.cs - Re-enabled corresponding test cases in ResourceIdFunctionsTests.cs
- Updated API surface files for all target frameworks (netstandard2.0, net8.0, net10.0) to reflect the reintroduced methods
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/provisioning/Azure.Provisioning/src/Expressions/BicepFunction.cs | Uncommented the GetResourceId and GetExtensionResourceId methods with their full documentation |
| sdk/provisioning/Azure.Provisioning/tests/Expressions/BicepFunctionTests/ResourceIdFunctionsTests.cs | Uncommented test cases TestGetResourceId and TestGetExtensionResourceId to validate the reintroduced functionality |
| sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.netstandard2.0.cs | Added API surface entries for the two reintroduced methods |
| sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.net8.0.cs | Added API surface entries for the two reintroduced methods |
| sdk/provisioning/Azure.Provisioning/api/Azure.Provisioning.net10.0.cs | Added API surface entries for the two reintroduced methods |
| sdk/provisioning/Azure.Provisioning/CHANGELOG.md | Documented the reintroduction of both methods in the 1.5.0-beta.1 release notes |
Review Summary: The changes are straightforward and consistent. The PR successfully reintroduces previously removed APIs by uncommenting existing code and tests. The implementation follows established patterns, includes comprehensive documentation, has adequate test coverage, and maintains API consistency across all target frameworks. No issues were identified within the scope of the changed code.
|
Close this because we would like to do this instead |
Description
Reintroduces
BicepFunction.GetResourceIdandBicepFunction.GetExtensionResourceIdAPIs that were temporarily removed in the 1.4.0 stable release pending API review. These methods provide access to the corresponding Bicep built-in functions for resource ID resolution.Changes
GetResourceId()andGetExtensionResourceId()methodsUsage
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.