Skip to content

Conversation

@Jefajers
Copy link
Member

Overview/Summary

This PR fixes the erroneous handling of Microsoft.Authorization/roleAssignments deletions that was introduced in AzOps 2.6.5 causing validate and push to fail when the roleAssignments had been removed out of bound.

This fixes #921.

This PR fixes/adds/changes/removes

  1. Changes Remove-AzOpsDeployment.ps1

Breaking Changes

N/A

Testing Evidence

With new logic validate does not fail:
image
With new logic push does not fail:
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the bug Something isn't working label Apr 11, 2025
@Jefajers Jefajers added this to the v2.8.0 milestone Apr 11, 2025
@Jefajers Jefajers requested review from a team as code owners April 11, 2025 11:49
@Jefajers Jefajers moved this to In progress in AzOps Apr 11, 2025
@Jefajers Jefajers moved this from In progress to Needs review in AzOps Apr 11, 2025
@Jefajers Jefajers moved this from Needs review to Pending release in AzOps Apr 14, 2025
@Jefajers Jefajers merged commit 097e3b2 into Azure:main Apr 14, 2025
4 checks passed
@Jefajers Jefajers deleted the roleAssignments branch April 14, 2025 09:21
@Jefajers Jefajers moved this from Pending release to Done in AzOps May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Deletion of role assignments causes null pointer if the role assignment was never successfully created

2 participants