-
Notifications
You must be signed in to change notification settings - Fork 16
fix(bluetooth): add forget button and improve connection reliability #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Chirag8405
commented
Nov 23, 2025
- Add unpair/forget functionality for paired devices
- Fix connection issues with already paired devices
- Improve device state tracking and refresh capability
- Add unpair/forget functionality for paired devices - Fix connection issues with already paired devices - Improve device state tracking and refresh capability
LeVraiArdox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall, just replace the commands with cpp modules like you did with the Wifi.
Also, can you send a screenshot of what this new layout looks like ? Thanks
|
|
||
| Process { | ||
| id: pairedDevicesFetcher | ||
| command: ["bluetoothctl", "devices", "Paired"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to use a module from the bluetooth.cpp/hpp plugins
|
|
||
| Quickshell.execDetached([ | ||
| "bash", "-c", | ||
| `bluetoothctl remove ${address}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for here. Let's prevent commands execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, working on it. Was busy with college exams
| if (pairedDevices.includes(address)) { | ||
| Quickshell.execDetached([ | ||
| "bash", "-c", | ||
| `bluetoothctl connect ${address}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you get it
|
What is this about ? |
| Timer { | ||
| id: refreshTimer | ||
| interval: 8000 | ||
| onTriggered: BluetoothService.refreshPairedDevices() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the idea of using a timer plz ?
| m_monitorProcess = new QProcess(this); | ||
| m_monitorProcess->setProcessChannelMode(QProcess::MergedChannels); | ||
| connect(m_monitorProcess, &QProcess::readyReadStandardOutput, this, &BluetoothService::parseMonitorOutput); | ||
| m_monitorProcess->start("bluetoothctl"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of using CPP was to use the QT bluetooth module or bluez. It should be a native component and not a command call
