Initial Gutenberg compatability #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the meta box to refresh the meta table when a Gutenberg post is saved. It does this very simply by just re-requesting the table HTML, rather than getting fancy with something like a JSON object and parsing it into DOM bits. Not elegant, but simple. Might fix #17. Thoughts @danielbachhuber?
Contributor
|
Honestly, I don't have a preference. This does seem like a hack but probably sufficient aside from entirely rewriting it like you mention. |
Merged
mjangda
requested changes
Dec 10, 2018
Updates from feedback: * Broke out AJAX table rendering to separate function * Added user capability check Other Updates: * Changed the way we checked for the block editor. We now user core enqueue_block_editor_assets to only load the necessary block editor JS
lkraav
reviewed
Dec 12, 2018
js/block-editor.js
Outdated
|
|
||
| wp.data.subscribe( | ||
| function() { | ||
| var isSaving = editPost.isSavingMetaBoxes(); |
Author
There was a problem hiding this comment.
Thanks! I think this got fixed in 5cc768a ... does it look correct to you now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the meta box to refresh the meta table when a Gutenberg post is saved. It does this very simply by just re-requesting the table HTML, rather than getting fancy with something like a JSON object and parsing it into DOM bits. Not elegant, but simple.
Might fix #17. Thoughts @danielbachhuber?