Skip to content

Issue #48: Use Navigation Component #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
recaldev wants to merge 3 commits into
base: development-mu8
Choose a base branch
from
Open

Issue #48: Use Navigation Component #51

recaldev wants to merge 3 commits into from

Conversation

@recaldev
Copy link
Collaborator

@recaldev recaldev commented Jan 26, 2020 •
edited
Loading

What's in:

  • Updated version for ship stats service to v3.

Testing Done:

  • On real device: Pixel 2 XL.

How it looks:

MU8NavComponent

How to test:

  • Launch the app and navigate through it.
  • Check the new navigation using the navigation components from JetPack.
  • Check that there is no error on any of the screens already implemented.

Signed-off-by:

@recaldev
Issue #48: Use Navigation Component to go from the Splash Screen to t…
dd6b1cf 
…he Categories Screen.

- Added dependencies for Navigation Component with Safe Args.
- Added Navigation Component for current Activities.

Signed-off-by: Diego Recalde <difereto89@gmail.com>
@recaldev
Merge branch 'development-mu8' into mu8/recaldev/issue-48
7a9130f 
# Conflicts:
#	presentation/src/main/java/com/architect/coders/mu8/categories/CategoriesActivity.kt
#	presentation/src/main/java/com/architect/coders/mu8/characters/CharactersActivity.kt
#	presentation/src/main/res/values/strings.xml
@recaldev
Issue #48: Use Navigation Component to go from the Splash Screen to t…
fc73e30 
…he Categories Screen.

- Added Navigation Component for Event Activity.
- Created approach for back navigation.

Signed-off-by: Diego Recalde <difereto89@gmail.com>
@recaldev recaldev added the enhancement New feature or request label Jan 26, 2020
@recaldev recaldev added this to the Navigation Component milestone Jan 26, 2020
@recaldev recaldev changed the title Issue # 48: Use Navigation Component Issue #48: Use Navigation Component Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamacado jamacado Awaiting requested review from jamacado

@SalosV SalosV Awaiting requested review from SalosV

@aliceresponde aliceresponde Awaiting requested review from aliceresponde

Assignees

@aliceresponde aliceresponde

@jamacado jamacado

@SalosV SalosV

Labels

enhancement New feature or request

Projects

None yet

Milestone

Navigation Component

Development

Successfully merging this pull request may close these issues.

5 participants

@recaldev @aliceresponde @jamacado @SalosV