Skip to content

Assignment notices get recorded in activity log #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylercraig9332 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Assignment notices get recorded in activity log #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bb30b6
Record Assignment Notice gets recorded in the activity log
tylercraig9332 Nov 2, 2017
4aae62a
forgot a simicolon lol
tylercraig9332 Nov 2, 2017
ee94518
Fixed a bug with some imports and namespacing
tylercraig9332 Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions class/Command/SendAssignmentNotificationCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
use \Homestead\HMS_Bed;
use \Homestead\HMS_RLC_Assignment;
use \Homestead\HMS_Email;
use \Homestead\HMS_Activity_Log;
use \Homestead\UserStatus;
use \Homestead\StudentFactory;
use \Homestead\NotificationView;
use \Homestead\Exception\PermissionException;
Expand Down Expand Up @@ -160,6 +162,7 @@ public function execute(CommandContext $context)

// Send the email
HMS_Email::sendAssignmentNotice($student, $student->getName(), $term, $location, $roommates, $movein_time);
HMS_Activity_Log::log_activity(UserStatus::getUsername(), ACTIVITY_ASSIGNMENT_NOTICE, $student->getUsername());

// Mark the student as having received an email
$db->reset();
Expand Down
3 changes: 2 additions & 1 deletion class/HMS_Activity_Log.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ public static function getActivityMapping()
ACTIVITY_CONTRACT_STUDENT_SIGN_EMBEDDED => 'Student Signed Contract via Embedded Signing',
ACTIVITY_CONTRACT_REMOVED_VOIDED => 'Removed Voided Contract',
ACTIVITY_MEAL_PLAN_SENT => 'Meal Plan Reported to Banner',
ACTIVITY_ROOM_DAMAGE_NOTIFICATION => 'Room damage notification sent'
ACTIVITY_ROOM_DAMAGE_NOTIFICATION => 'Room damage notification sent',
ACTIVITY_ASSIGNMENT_NOTICE => 'Assignment notice sent'
);
}

Expand Down
3 changes: 2 additions & 1 deletion inc/defines.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,8 @@

define('ACTIVITY_MEAL_PLAN_SENT', 83); // Meal plan reported to Banner

define('ACTIVITY_ROOM_DAMAGE_NOTIFICATION', 84); // Room damage notification
define('ACTIVITY_ROOM_DAMAGE_NOTIFICATION', 84); // Room damage notification
define('ACTIVITY_ASSIGNMENT_NOTICE', 85);

/**
* Errors
Expand Down