Implement Max operator #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbittar
reviewed
Aug 4, 2025
grammar/Expr.g4
Outdated
| | IDENTIFIER '[' expr ']' # timeIndex | ||
| | '(' expr ')' '[' shift ']' # timeShiftExpr | ||
| | '(' expr ')' '[' expr ']' # timeIndexExpr | ||
| | 'max' '(' expr (',' expr)* ')' # maxExpr |
Collaborator
There was a problem hiding this comment.
It should be MAX here, no ?
Collaborator
Author
There was a problem hiding this comment.
It depends, we want MAX or max as operand?
src/gems/expression/copy.py
Outdated
|
|
||
| @dataclass(frozen=True) | ||
| class CopyVisitor(ExpressionVisitorOperations[ExpressionNode]): | ||
| class CopyVisitor(ExpressionVisitorOperations[ExpressionNode]): # type: ignore |
Collaborator
There was a problem hiding this comment.
Why do you need #type : ignore ?
Collaborator
Author
There was a problem hiding this comment.
it depends with what ExpressionVisitorOperations returns. If it returns ExpressionNode, it is ok, if it returns T, we need to ignore
| def port_field_aggregator(self, node: PortFieldAggregatorNode) -> float: | ||
| raise NotImplementedError() | ||
|
|
||
| def max_node(self, node: MaxNode) -> float: # type: ignore |
Collaborator
There was a problem hiding this comment.
Why do you need type : ignore ?
src/gems/expression/visitor.py
Outdated
| """ | ||
| import typing | ||
|
|
||
| from typing import cast |
| return left_value / right_value | ||
|
|
||
| def max_node(self, node: MaxNode) -> ExpressionNode: # type: ignore | ||
| return MaxNode(operands=[visit(op, self) for op in node.operands]) # type: ignore |
Collaborator
Author
There was a problem hiding this comment.
Because it returns ExpressionNode, wich is not homogene with ExpressionVisitor abstract method and the visit method
tests/unittests/expressions/visitor/test_max_expression_checker.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.