Skip to content

Fix live reload infinite loop on uvicorn >= 0.39 #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jph00 merged 1 commit into from
Jan 4, 2026
Merged

Fix live reload infinite loop on uvicorn >= 0.39 #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion fasthtml/live_reload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from starlette.routing import WebSocketRoute
from starlette.websockets import WebSocketDisconnect
from fasthtml.basics import FastHTML, Script

__all__ = ["FastHTMLWithLiveReload"]
Expand All @@ -23,7 +24,11 @@ def LiveReloadJs(reload_attempts:int=20, reload_interval:int=1000, **kwargs):
"""
return Script(src % (reload_attempts, reload_interval))

async def live_reload_ws(websocket): await websocket.accept()
async def live_reload_ws(websocket):
await websocket.accept()
try:
while True: await websocket.receive()
Copy link
Contributor Author

@erikgaas erikgaas Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent to just saying "wait forever until we get a disconnect". This appears to be idiomatic for websockets.

except WebSocketDisconnect: pass

class FastHTMLWithLiveReload(FastHTML):
"""
Expand Down