Add Apple sign in #813
Merged
Add Apple sign in #813
+229
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/813 |
Contributor
|
Nice one @erikgaas ! :) If you move jwt to being a dev requirement, and then only import it inside the functions where it's used, then it doesn't add a dep for everyone. |
Contributor
Author
Nice! good idea. changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding sign in with apple. It is slightly different because it requires parsing a p8 file and a post request for the redirect if you want name and email.
Adding PyJWT as a req. It's small and fairly ubiquitous, but I'm down to reconsider.
Fun fact apple sign in does not work on localhost which is super annoying, but you can use solveit easily to test it out : )