[OGUI-1851] ObjectInfo Panel on hover should be left/right depending on position #3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
graduta
requested changes
Dec 18, 2025
| const { name, id } = tabObject; | ||
| const { filterModel, router, object, services } = model; | ||
| const isSelectedOpen = object.selectedOpen; | ||
| const isSelectedOpen = object.selectedOpenName === id; |
Member
There was a problem hiding this comment.
Doing this, it means that the selection will stay open only for one object which is not what we desired.
The functionality was requested and implemented in such a way that the users can quickly hover over the objects in sequence with the pop-up staying open so that they can compare the metadata.
Comment on lines
49
to
60
| { | ||
| style: 'right:0.1em; width: 35em;left: auto;', | ||
| onupdate: (vnode) => { | ||
| if (object.isOnLeftSide(vnode.dom.parentElement)) { | ||
| vnode.dom.style.left = '0.1em'; | ||
| vnode.dom.style.right = 'auto'; | ||
| } else { | ||
| vnode.dom.style.right = '0.1em'; | ||
| vnode.dom.style.left = 'auto'; | ||
| } | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
Would it not be better to calculate the style position above and use it here directly rather than setting a position on L50, just to modify after?
| * @returns {boolean|undefined} Returns true if the element is on the left half of the window, | ||
| * false if it is on the right half, or undefined if no element is provided. | ||
| */ | ||
| isOnLeftSide(element) { |
Member
There was a problem hiding this comment.
I think this would be better in a util folder so that other components can use it if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
When viewing a layout, the user has the option to hover over a plot and get multiple options. Here, they can click on the
infoicon to get a panel with information about the object.The problem lies of the fact that if the object is positioned on the left side of the screen, it will not be visible properly.
Now when we are on the left side of the window it will render the dropdown to the right of the button anchor.