[OGUI-1842] Add panel with run information in QCG under filters #3232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`retrieveRunInformation`
…be set. Clear runInformation on clearFilters()
graduta
changed the base branch from
dev
to
feature/QCG/OGUI-1840/Refactor-the-response-object-of-retrieveRunStatus
…he correct data on success
…e run information
…bject-of-retrieveRunStatus
…etrieveRunStatus' into feature/QCG/OGUI-1842/panel-with-run-information
Base automatically changed from
feature/QCG/OGUI-1840/Refactor-the-response-object-of-retrieveRunStatus
to
dev
December 17, 2025 09:59
graduta
requested changes
Dec 17, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
Good job on the initial push! I left a few comments but nothing major
Comment on lines
108
to
122
| cleanRunInformation && Object.keys(cleanRunInformation).length > 0 && h( | ||
| '.flex-row.g4.items-center.f7.gray-darker.text-center.ph4', | ||
| { | ||
| id: 'header-run-information', | ||
| style: 'overflow-x: auto; margin: 0 auto;', | ||
| }, | ||
| Object.entries(cleanRunInformation).map(([key, value]) => | ||
| h('.flex-row.g1', { | ||
| key: `${key}-${value}`, | ||
| style: 'flex: 0 0 auto;', | ||
| }, [ | ||
| h('strong', `${camelToTitleCase(key)}:`), | ||
| h('span', `${value}`), | ||
| ])), | ||
| ), |
Member
There was a problem hiding this comment.
I believe this should be extracted in an independent component to make the code easier to read.
Similar to the line above with lastUpdatePanel
| ])), | ||
| ), | ||
| Array.isArray(detectorsQualities) && detectorsQualities.length > 0 && h( | ||
| '.flex-row.g3.items-center.f7.gray-darker.text-center.ph3', |
Member
There was a problem hiding this comment.
Similar to above, please extract this in a component
| * If `this.runNumber` is defined, it asynchronously retrieves the run information | ||
| * via `filterService.getRunInformation(runNumber)` and sets it to `runInformation`, | ||
| * automatically applying any filtering and transformations defined in the setter. | ||
| * If `this.runNumber` is not defined, `runInformation` is reset to an empty object. |
| * Sets the run information after filtering and transforming values. | ||
| * - Filters out properties that are `null` or `undefined`. | ||
| * - Applies a transformation function from `RUN_INFORMATION_MAP` for any matching keys. | ||
| * @param {object} value - The new run information object to set. |
Member
There was a problem hiding this comment.
I believe in the previous PR you have added a typedef to better describe what object we receive Can you please make use of it here rather than the object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
retrieveRunStatus#3229retrieveRunStatus#3229 that is fetched from Bookkeeping.