[QC-1297] Accept pure json as value instead of a string containing json. #2617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more elegant way would be to use a variant in the mCustomParameters data structure. However, it implies making quite many changes to check what we are dealing with in every existing method, and some of them would need heavy refactoring (e.g. find()). Given that the overhead of the proposed solution is minimal, I would stick with it.
Barthelemy
changed the title
Barthelemy
changed the title
knopers8
approved these changes
Oct 30, 2025
| for (const auto& [key, value] : subTreeBeamType) { | ||
| set(key, value.get_value<std::string>(), runtype, beamtype); | ||
| // Check if value has children (thus it is json) | ||
| if (value.empty()) { // just a simple value |
Collaborator
There was a problem hiding this comment.
I could not believe that empty() checks if there are children, but indeed it does... https://github.com/boostorg/property_tree/blob/2669458cebee100bc1f9f4a9d2f0cd95d07740bc/include/boost/property_tree/ptree.hpp#L107
akavumpa
pushed a commit
to akavumpa/QualityControl
that referenced
this pull request
Nov 7, 2025
…on. (AliceO2Group#2617) * [QC-1297] Accept pure json as value instead of a string containing json. A more elegant way would be to use a variant in the mCustomParameters data structure. However, it implies making quite many changes to check what we are dealing with in every existing method, and some of them would need heavy refactoring (e.g. find()). Given that the overhead of the proposed solution is minimal, I would stick with it. * Update CustomParameters.cxx * expand the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more elegant way would be to use a variant in the mCustomParameters data structure. However, it implies making quite many changes to check what we are dealing with in every existing method, and some of them would need heavy refactoring (e.g. find()). Given that the overhead of the proposed solution is minimal, I would stick with it.