Skip to content

[DPG] Specify collisions type in QA efficiency task #14340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fgrosa wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DPG] Specify collisions type in QA efficiency task #14340

fgrosa wants to merge 2 commits into from
+21 −21

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Dec 23, 2025

This PR fixes the following error:

Unhandled o2::framework::runtime_error reached the top of main of o2-analysis-qa-efficiency, device shutting down. Reason: Trying to dereference index with a wrong type in collision_as<T> for base target "Collisions". Note that if you have several compatible index targets in your process() signature, the last one will be the one actually bound.

That is obtained in case the processMCWithoutCollisions is used

@github-actions github-actions bot added the dpg label Dec 23, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025 •
edited
Loading

O2 linter results: ❌ 24 errors, ⚠️ 32 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Specify collisions type in QA efficiency task [DPG] Specify collisions type in QA efficiency task Dec 23, 2025
@alibuild
Copy link
Collaborator

alibuild commented Dec 24, 2025

Error while checking build/O2Physics/o2 for eba674a at 2025-12-24 01:05:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1077:11: error: need 'typename' before 'Colls::iterator' because 'Colls' is a dependent scope
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:12: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:53: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 24, 2025

Error while checking build/O2Physics/o2 for 9bed191 at 2025-12-24 15:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1080:22: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'has_mcCollision'
/sw/SOURCES/O2Physics/14340-slc9_x86-64/0/DPG/Tasks/AOTTrack/qaEfficiency.cxx:1083:63: error: 'const struct o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> > >' has no member named 'mcCollision'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

Assignees

No one assigned

Labels

dpg

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgrosa @alibuild @njacazio