Skip to content

[PWGCF,PWGHF] Fix an issue introduced in the previous PR in the FemtoDream derived data model #14327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 3 commits into from
Dec 22, 2025
Merged

[PWGCF,PWGHF] Fix an issue introduced in the previous PR in the FemtoDream derived data model #14327

zhangbiao-phy merged 3 commits into from
Dec 22, 2025
+58 −25

Conversation

@zhangbiao-phy
Copy link
Collaborator

@zhangbiao-phy zhangbiao-phy commented Dec 22, 2025 •
edited
Loading

Hi @AntonRiedel @gmantzar, I am sorry for introducing an issue in my previous PR!

In this PR:

  • I fixed the issue related to the particle type enum
  • I added the missing changes for the charm sector, in particular for D*, which I intended to include but accidentally missed in the previous PR

Please let me know if I missed anything. Thank you very much!

@github-actions
Copy link

github-actions bot commented Dec 22, 2025 •
edited
Loading

O2 linter results: ❌ 40 errors, ⚠️ 5 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Fix a issue induce from last PR in femto dream derived data model [PWGCF,PWGHF] Fix a issue induce from last PR in femto dream derived data model Dec 22, 2025
@zhangbiao-phy zhangbiao-phy changed the title [PWGCF,PWGHF] Fix a issue induce from last PR in femto dream derived data model [PWGCF,PWGHF] Fix an issue introduced in the previous PR in the FemtoDream derived data model Dec 22, 2025
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review December 22, 2025 13:36
vkucera
vkucera reviewed Dec 22, 2025
View reviewed changes
@zhangbiao-phy zhangbiao-phy marked this pull request as draft December 22, 2025 14:48
@zhangbiao-phy zhangbiao-phy marked this pull request as ready for review December 22, 2025 19:04
@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) December 22, 2025 19:05
alibuild
alibuild approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zhangbiao-phy.

@zhangbiao-phy zhangbiao-phy merged commit 2c3bc27 into AliceO2Group:master Dec 22, 2025
13 of 14 checks passed
@zhangbiao-phy zhangbiao-phy deleted the fxi_charmfemto branch December 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild alibuild approved these changes

@ariedel-cern ariedel-cern ariedel-cern approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangbiao-phy @alibuild @vkucera @ariedel-cern