[PWGHF] taskLc: configure thn axes for bdtScore prompt and nonprompt individually #14306
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubynets
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
Collaborator
|
hi @lubynets, actually in most analyses, prompt and non-prompt BDT scores are used with the same binning (typically 100 bins is always enough). When higher prompt purity is needed, this is usually achieved by applying a cut on the prompt BDT score. But there is no hurt to set prompt and non-prompt axis individually. |
zhangbiao-phy
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for now the THnSparse axes for BDT prompt and non-prompt scores are configured via the same
ConfigurableAxis,thnConfigAxisBdtScoreSignal. However that's not optimal since it significantly increases number of THnSparse cells, while information about both BDT prompt and nonprompt score may be redundant (major vast of analyses are nonprompt-score oriented).This PR introduces two individual
ConfigurableAxis:thnConfigAxisBdtScorePromptandthnConfigAxisBdtScoreNonPromptinstead of previousthnConfigAxisBdtScoreSignal, which will allow for reducing the THnSparse binning and thus avoid OOM issues at HY.