-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGHF] Add preselection and centrality to st tree creator #14252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[PWGHF] Add preselection and centrality to st tree creator #14252
Conversation
Fix a name bug.
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
Added new mass columns for Omega and Xi particles and updated event selection criteria.
…ty-to-STTree-creatore
…ty-to-STTree-creatore
Please consider the following formatting changes to AliceO2Group#14252
Please consider the following formatting changes to AliceO2Group#14252
|
Stop wasting compilation resources! Your PR doesn't pass required tests and you haven't addressed my comments, so why did you open the PR for review? |
Please consider the following formatting changes to AliceO2Group#14252
| setLabelHistoCands(hCandidatesCascPiOrK); | ||
|
|
||
| // init HF event selection helper (centrality, event cuts, monitoring) | ||
| hfEvSel.init(registry, nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nullptr is useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Vit. This is recommended by Fabrizio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
…ty-to-STTree-creatore
| enum ChannelType { | ||
| ANY = 0, | ||
| XIC_TO_XI_PI = 1, | ||
| XIC_TO_OMEGA_KA = 2, | ||
| OMEGAC_TO_OMEGA_PI = 3, | ||
| OMEGAC_TO_OMEGA_KA = 4, | ||
| OMEGAC_TO_XI_PI = 5 | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow naming conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, please tell me directly, where is the problem with the name?
No description provided.