[Common,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD,DPG,Trigger] [Cleanup] Add fully qualified names for std::string and std::map #12378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header TJAlienCredentials.h polluted the global namespace, included usually with CCDB or something related. See AliceO2Group/AliceO2#14524 This commit prepares for the removal of the polluted namespace. The libraries/repo with TJAlienCredentials is JAliEn-ROOT and libjalieno2. The problem was first noticed by @vkucera.
mrtineide
requested review from
a team,
ChiaraDeMartin95,
alibuild,
altsybee,
ddobrigk,
dmallick2,
dsekihat,
ekryshen,
ercolessi,
feisenhu,
hscheid,
iarsene,
ivorobye,
jgrosseo,
ktf,
lauraser,
lietava,
lucamicheletti93,
mcoquet642,
mikesas,
mpuccio,
pbuehler,
rbailhac,
rolavick,
romainschotter,
skundu692,
smaff92 and
strogolo
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 1381 errors, |
rolavick
approved these changes
Aug 1, 2025
romainschotter
approved these changes
Aug 1, 2025
Contributor
Author
|
I can prepare a new commit on the same branch that also adds the standard headers (#include) where MegaLinter gives errors. |
ekryshen
approved these changes
Aug 1, 2025
mpuccio
approved these changes
Aug 4, 2025
Collaborator
|
Thanks @mrtineide ! |
mhemmer-cern
approved these changes
Aug 6, 2025
skundu692
approved these changes
Aug 7, 2025
ivorobye
approved these changes
Aug 7, 2025
iarsene
approved these changes
Aug 7, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
…y qualified names for std::string and std::map (AliceO2Group#12378)
GijsvWeelden
pushed a commit
to GijsvWeelden/O2Physics
that referenced
this pull request
Aug 14, 2025
…y qualified names for std::string and std::map (AliceO2Group#12378)
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…y qualified names for std::string and std::map (AliceO2Group#12378)
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
…y qualified names for std::string and std::map (AliceO2Group#12378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header TJAlienCredentials.h polluted the global namespace, included usually with CCDB or something related.
See AliceO2Group/AliceO2#14524 for more background.
This prepares for the removal of the polluted namespace.