Skip to content

Conversation

@hkoley
Copy link
Contributor

@hkoley hkoley commented Jul 20, 2025

  1. Added new process function for rotational method
  2. Improved efficiency of the analysis task
  3. Added a switch for QA plots in collisionCuts.h

hkoley added 2 commits July 21, 2025 04:08
1. Added new process function for rotational method
2. Improved efficiency of the analysis task
@github-actions
Copy link

github-actions bot commented Jul 20, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

dmallick2
dmallick2 previously approved these changes Jul 21, 2025
@vkucera
Copy link
Collaborator

vkucera commented Jul 21, 2025

@hkoley @dmallick2 Please do not ignore the failing tests.
cpplint reports missing C++ headers. They might not be the only ones. Please check the instructions on how to include what you use.

dmallick2
dmallick2 previously approved these changes Jul 22, 2025
dmallick2
dmallick2 previously approved these changes Jul 22, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 52c528e at 2025-07-23 13:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:1078:88: error: 'kLambda1520_Py' was not declared in this scope; did you mean 'kLambda1520'?
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:974:46: error: 'kLambda1520_Py' was not declared in this scope; did you mean 'kLambda1520'?
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:1094:39: error: 'kLambda1520_Py' was not declared in this scope; did you mean 'kLambda1520'?
/sw/slc9_x86-64/O2/daily-20250723-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(Lambda1520analysisinpp*&)'
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera previously approved these changes Jul 23, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 74ff38f at 2025-07-24 09:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:225:498: error: unable to find numeric literal operator 'operator""f'
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:225:738: error: could not convert '{"binsPtQA", {o2::framework::VARIABLE_WIDTH, 0.0f, 2.00000003e-1f, 4.00000006e-1f, 6.00000024e-1f, 8.00000012e-1f, 1.0e+0f, 1.20000005e+0f, 1.39999998e+0f, 1.60000002e+0f, 1.79999995e+0f, 2.0e+0f, 2.20000005e+0f, 2.4000001e+0f, 2.5999999e+0f, 2.79999995e+0f, 3.0e+0f, 3.20000005e+0f, 3.4000001e+0f, 3.5999999e+0f, 3.79999995e+0f, 4.0e+0f, 4.19999981e+0f, 4.4000001e+0f, 4.5999999e+0f, 4.80000019e+0f, 5.0e+0f, 5.19999981e+0f, 5.4000001e+0f, 5.5999999e+0f, 5.80000019e+0f, 6.0e+0f, 6.19999981e+0f, 6.4000001e+0f, 6.5999999e+0f, 6.80000019e+0f, 7.0e+0f, 7.19999981e+0f, 7.4000001e+0f, 7.5999999e+0f, 7.80000019e+0f, 8.0e+0f, 8.19999981e+0f, 8.39999962e+0f, 8.60000038e+0f, 8.80000019e+0f, 9.0e+0f, 9.19999981e+0f, 9.39999962e+0f, 9.60000038e+0f, 9.80000019e+0f, 1.0e+1f, 1.01999998e+1f, 1.03999996e+1f, 1.06000004e+1f, 1.08000002e+1f, 1.1e+1f, 1.11999998e+1f, 1.13999996e+1f, 1.16000004e+1f, 1.18000002e+1f, 1.2e+1f, 1.21999998e+1f, 1.23999996e+1f, 1.26000004e+1f, 1.28000002e+1f, 1.3e+1f, 1.31999998e+1f, 1.33999996e+1f, 1.36000004e+1f, 1.38000002e+1f, <expression error>, 1.41999998e+1f, 1.43999996e+1f, 1.46000004e+1f, 1.48000002e+1f, 1.5e+1f, 1.51999998e+1f, 1.53999996e+1f, 1.56000004e+1f, 1.58000002e+1f, 1.6e+1f, 1.62000008e+1f, 1.63999996e+1f, 1.66000004e+1f, 1.67999992e+1f, 1.7e+1f, 1.72000008e+1f, 1.73999996e+1f, 1.76000004e+1f, 1.77999992e+1f, 1.8e+1f, 1.82000008e+1f, 1.83999996e+1f, 1.86000004e+1f, 1.87999992e+1f, 1.9e+1f, 1.92000008e+1f, 1.93999996e+1f, 1.96000004e+1f, 1.97999992e+1f, 2.0e+1f}, "Binning of the pT axis"}' from '<brace-enclosed initializer list>' to 'o2::framework::ConfigurableAxis' {aka 'o2::framework::Configurable<std::vector<double>, o2::framework::kAxisSpec, o2::framework::ConfigurablePolicyConst<std::vector<double>, o2::framework::kAxisSpec> >'}
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:1078:85: error: no match for 'operator==' (operand types are 'o2::framework::expressions::Node' and 'o2::constants::physics::Pdg')
/sw/slc9_x86-64/O2/daily-20250724-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(Lambda1520analysisinpp*&)'
ninja: build stopped: subcommand failed.

Full log here.

dmallick2
dmallick2 previously approved these changes Jul 24, 2025
@hkoley hkoley dismissed stale reviews from dmallick2 and vkucera via 7764eee July 24, 2025 16:47
@vkucera vkucera marked this pull request as draft July 24, 2025 19:04
@hkoley hkoley marked this pull request as ready for review July 24, 2025 19:53
@dmallick2 dmallick2 enabled auto-merge (squash) July 24, 2025 20:27
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 7764eee at 2025-07-25 01:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12164-slc9_x86-64/0/PWGLF/Tasks/Resonances/lambda1520analysisinpp.cxx:1078:62: error: no matching function for call to 'abs(const o2::framework::expressions::BindingNode&)'
/sw/slc9_x86-64/O2/daily-20250724-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(Lambda1520analysisinpp*&)'
ninja: build stopped: subcommand failed.

Full log here.

@dmallick2 dmallick2 merged commit c2290e7 into AliceO2Group:master Jul 25, 2025
14 checks passed
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jul 25, 2025
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants