[Common,PWGCF,DPG] TimeDeadMap needs explicit dependence on O2::DataFormatsITSMFT #11742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
a team,
alibuild,
altsybee,
ariedel-cern,
ddobrigk,
ekryshen,
glromane,
iarsene,
jgrosseo,
ktf,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
strogolo,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 3 errors, |
github-actions
bot
changed the title
victor-gonzalez
approved these changes
Jun 24, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Thanks @shahor02!
Collaborator
|
Thanks @shahor02 |
fgrosa
pushed a commit
that referenced
this pull request
Jul 15, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jul 18, 2025
JimunLee
pushed a commit
to JimunLee/O2Physics
that referenced
this pull request
Jul 22, 2025
vojmach
pushed a commit
to vojmach/O2Physics
that referenced
this pull request
Jul 23, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vkucera the TimeDeadMap was not meant to be header only, so the CMakeLists should explicitly depend on O2::DataFormatsITSMFT. Once the AliceO2Group/AliceO2#14436 is merged, then the
#include "DataFormatsITSMFT/NoiseMap.h"can be removed from the O2Phyiscs.