Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Jun 23, 2025

Due to changes in how the column getters work made in AliceO2Group/AliceO2#14421 the single-valued columns return an rvalue, while fixed- and variable-size array columns return a span. This requires some small changed throughout O2Physics where these kinds of columns are accessed.

@aalkin aalkin requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners June 23, 2025 10:20
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

O2 linter results: ❌ 173 errors, ⚠️ 0 warnings, 🔕 45 disabled

@github-actions github-actions bot changed the title DPL Analysis: fix for reworked column getters [Common] DPL Analysis: fix for reworked column getters Jun 23, 2025
@github-actions github-actions bot added the pwgud label Jun 23, 2025
@aalkin aalkin changed the title [Common] DPL Analysis: fix for reworked column getters [Common, PWGUD] DPL Analysis: fix for reworked column getters Jun 23, 2025
@github-actions github-actions bot changed the title [Common, PWGUD] DPL Analysis: fix for reworked column getters [Common,PWGUD] DPL Analysis: fix for reworked column getters Jun 23, 2025
@aalkin aalkin changed the title [Common,PWGUD] DPL Analysis: fix for reworked column getters [Common, PWGUD, PWGLF] DPL Analysis: fix for reworked column getters Jun 23, 2025
@github-actions github-actions bot changed the title [Common, PWGUD, PWGLF] DPL Analysis: fix for reworked column getters [Common,PWGUD,PWGLF] DPL Analysis: fix for reworked column getters Jun 23, 2025
@github-actions github-actions bot added the pwghf PWG-HF label Jun 23, 2025
@aalkin aalkin changed the title [Common,PWGUD,PWGLF] DPL Analysis: fix for reworked column getters [Common,PWGUD,PWGLF,PWGHF] DPL Analysis: fix for reworked column getters Jun 23, 2025
vkucera
vkucera previously approved these changes Jun 23, 2025
rolavick
rolavick previously approved these changes Jun 23, 2025
@aalkin
Copy link
Member Author

aalkin commented Jun 23, 2025

@vkucera @ddobrigk thank you for your approval, but I'm still collecting the changes. There are some unexpected uses of the old API that are not always obvious how to fix. There will be more commits.

@vkucera vkucera marked this pull request as draft June 23, 2025 12:22
@vkucera
Copy link
Collaborator

vkucera commented Jun 23, 2025

@vkucera @ddobrigk thank you for your approval, but I'm still collecting the changes. There are some unexpected uses of the old API that are not always obvious how to fix. There will be more commits.

Thanks @aalkin for the clarification. I would keep the PR as a draft then until all commits are pushed.

@aalkin aalkin dismissed stale reviews from rolavick and vkucera via ae56a9e June 23, 2025 14:01
@aalkin
Copy link
Member Author

aalkin commented Jun 24, 2025

The amount of changes required is too large for a one-off PR. It will be done in a smaller, manageable steps.

@aalkin aalkin closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants