Skip to content

Conversation

@mhemmer-cern
Copy link
Collaborator

Adds EMCal cross talk emulation for MC.
Configurables are handled via EmcCrossTalkConf inside the correction task. The cross talk itself is contained within emcalCrossTalkEmulation.cxx and emcalCrossTalkEmulation.h. Since the cross talk can create new cells which are not inside the AO2Ds original cell table, those new cells will not be stored within the table that mappes clusterIDs to cellIDs!

@github-actions github-actions bot added the pwgje label Jun 10, 2025
@github-actions
Copy link

github-actions bot commented Jun 10, 2025

O2 linter results: ❌ 8 errors, ⚠️ 0 warnings, 🔕 5 disabled

@mhemmer-cern
Copy link
Collaborator Author

This PR needs this one from O2: AliceO2Group/AliceO2#14385
Since we it requires a change in the EMCal base class CellLabel!

@mhemmer-cern mhemmer-cern force-pushed the EMCAL-1154 branch 2 times, most recently from 07c5b60 to f2471a4 Compare June 16, 2025 09:45
@mhemmer-cern mhemmer-cern marked this pull request as ready for review June 20, 2025 07:50
@mhemmer-cern
Copy link
Collaborator Author

First version of the cross talk emulation. Newly generated cells will not be filled in the EMCALClusterCell table since they do not have an entry in the original cell table.

@fjonasALICE
Copy link
Collaborator

I will check this. Extra eyes would help when you have a minute @nstrangm & @jokonig

@jokonig
Copy link
Contributor

jokonig commented Jul 2, 2025

@fjonasALICE looks good to me (Sorry for the delay from my side). I think the effect can then only be evaluated once its merged and we check the M02 distributions etc. on the full MC production.

@mhemmer-cern
Copy link
Collaborator Author

There is a commit coming with updated default values based on the feedback I received.
Once I could confirm running with those values I will make push.

fjonasALICE
fjonasALICE previously approved these changes Jul 11, 2025
@fjonasALICE fjonasALICE enabled auto-merge (squash) July 11, 2025 14:54
@fjonasALICE fjonasALICE disabled auto-merge July 11, 2025 14:55
@fjonasALICE
Copy link
Collaborator

@mhemmer-cern approved but now there are merge conflicts, please fix and ping me again

Adds EMCal cross talk emulation for MC.
Configurables are handled via `EmcCrossTalkConf` inside the correction task.
The cross talk itself is contained within `emcalCrossTalkEmulation.cxx` and `emcalCrossTalkEmulation.h`.
Since the cross talk can create new cells which are not inside the AO2Ds original cell table, those new cells will not be stored within the table that mappes clusterIDs to cellIDs!

[PWGJE,EMCAL-1154] Update default values

- Added link to the default yaml file for the emcal configuration from where the deafult values where taken and added newer default values with reference to this paper: https://cds.cern.ch/record/2910556/
@mhemmer-cern
Copy link
Collaborator Author

@fjonasALICE @jokonig I updated to PR, working on the merge conflicts. Please check carefully. I hope I did not accidentally remove anything from the previous PRs.

@mhemmer-cern mhemmer-cern enabled auto-merge (squash) July 23, 2025 14:16
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern mhemmer-cern merged commit fa8511e into AliceO2Group:master Jul 23, 2025
11 of 13 checks passed
@mhemmer-cern mhemmer-cern deleted the EMCAL-1154 branch July 23, 2025 14:16
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants