Skip to content

Conversation

@romainschotter
Copy link
Contributor

@romainschotter romainschotter commented Oct 6, 2025

  • update existing DPL configurations
  • add new DPL configurations for the most up-to-date task

This PR is linked to AliceO2Group/O2Physics#13261

@catalinristea for your information

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@romainschotter romainschotter marked this pull request as ready for review October 6, 2025 22:25
@sawenzel sawenzel requested a review from catalinristea October 7, 2025 08:42
@sawenzel
Copy link
Contributor

sawenzel commented Oct 9, 2025

@romainschotter : Please ping back here as soon as your O2Physics PR is merged. We can then merge it here too.

@catalinristea : We should then make sure to always use latest software for the analysis QC (at least the MC "first tag").

@romainschotter
Copy link
Contributor Author

Hi @sawenzel (and @jackal1-66 ),
The PR in O2Physics (AliceO2Group/O2Physics#13261) just got merged.
Thanks a lot!

@sawenzel sawenzel changed the title Update DPL configurations Update DPL configurations related to analysis QC Oct 9, 2025
@sawenzel sawenzel enabled auto-merge (squash) October 9, 2025 09:53
@f3sch
Copy link
Contributor

f3sch commented Oct 23, 2025

@romainschotter, the failing check seems relevant to me?

@romainschotter
Copy link
Contributor Author

Hi @f3sch !
I am aware of the failed compilation check. However, I am not entirely sure to understand it. It looks like it is trying to run all configurations at once and this creates a clash between the old table producers and the new ones (the one I added for the K0s QC task) as they produce the same tables, hence O2 complains about duplicated outputs.
It should not happen, though, as my changes only concern the dependencies of the K0s QC task which has no duplicated outputs.
I already discussed it with @jackal1-66 and @sawenzel who are aware of this issue

auto-merge was automatically disabled October 27, 2025 12:48

Head branch was pushed to by a user without write access

@romainschotter
Copy link
Contributor Author

Hi @sawenzel and @jackal1-66,
I have made some changes in the PR.
One small change concerns the configurations of the multcentable and pidtpcservice:

  • global counters have been disabled in multcenttable configurations, which should now match the configuration of the multcenttable service core wagon in Hyperloop
  • the use of Neural Network have been disabled in the pidtpcservice.

Another (bigger) change concerns the dependencies of all workflows in analysis_config.json which have been updated with the latest set of dependencies. This will allow the PR to pass the build/O2DPG/sim/o2 check.
However, we should also make sure the configuration for these updated dependencies is still correct for each workflow.
Pinging @catalinristea , @alcaliva , as well as

Thank you very much!

@njacazio
Copy link
Contributor

Thanks a lot!

@nstrangm
Copy link

Hi @romainschotter,
thank you! I don't see any issues from EMCal side, as long as it still runs (which I did not test myself now), the results should still be good.
Best,
Nicolas

@sawenzel sawenzel merged commit 759c1a1 into AliceO2Group:master Oct 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants