[OCTRL-1064] GO_ERROR calls should never be critical #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having to handle a failed GO_ERROR transition is something we should avoid. An interrupted GO_ERROR means that we might not perform the complete procedure and miss e.g. calling some services/subsystems. With this change, the only known way of failing GO_ERROR is to try it in an inappropriate state, which can be ERROR (no point in transitioning from ERROR to ERROR) or DONE (too late, nothing to do).
justonedev1
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to handle a failed GO_ERROR transition is something we should avoid. An interrupted GO_ERROR means that we might not perform the complete procedure and miss e.g. calling some services/subsystems.
With this change, the only known way of failing GO_ERROR is to try it in an inappropriate state, which can be ERROR (no point in transitioning from ERROR to ERROR) or DONE (too late, nothing to do).