[O2B-1517] Fix table row loading check #2047
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of rows must be different to that of the previous test otherwise waitForTable will execute and move on before the new data has been loaded. Therefore new test case added that will result in different number of rows prior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 45.43% 45.40% -0.03%
==========================================
Files 1028 1028
Lines 17136 17136
Branches 3120 3120
==========================================
- Hits 7785 7780 -5
- Misses 9351 9356 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Moved the assertion for the dropup button text after waiting for the table length.
…iceO2Group/Bookkeeping into improv/O2B-1517/fix-failing-runs-test
Inserted calls to waitForTableLength before table data validation to ensure the table is fully loaded before assertions.
The waitForTableToLength function now accepts an optional timeout parameter. Updated overview.test.js to use a 5000ms timeout when waiting for table rows in a troublesome test.
Corrects the selector for detecting loading rows. It should check for 'tbody' not body and understand that it can return an empty list and the double ! operator will treat this as a truthy value which is incorrect.
Houwie7000
previously approved these changes
Dec 18, 2025
Confirm reset is finished before proceeding with further test actions. Issue with reset and debounce and assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForTableLengthwas updated to support longer timeouts, which are required for some slower or flaky tests. During this change, an issue was identified in how the helper checked for the presence of a loading row; this logic was incorrect and has now been fixed.The usage of
waitForTableLengthwas also added or adjusted across multiple tests to ensure assertions run at the correct time. Additionally, a new test case was introduced to cover a scenario where the expected row count matches the previous row count. In this case, the assertion could run before the table finished loading, leading to failures in subsequent assertions.I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: