Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHCfills page now has a total run duration filter.

Notable changes for developers:

  • GetAllLhcFillsUseCase.js will now execute a JOIN on statistics (fill_statistics) when runDuration and runDurationOperator are defined in the filter.

Changes made to the database:
-None.

@Houwie7000 Houwie7000 requested a review from isaachilly December 4, 2025 13:18
@Houwie7000 Houwie7000 self-assigned this Dec 4, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.29%. Comparing base (a533088) to head (6f77e0c).

Files with missing lines Patch % Lines
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 12 Missing ⚠️
...onents/Filters/LhcFillsFilter/runDurationFilter.js 0.00% 3 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           feature/O2B-1505/lhcfills-beam-duration-filter    #2038      +/-   ##
==================================================================================
- Coverage                                           45.48%   45.29%   -0.20%     
==================================================================================
  Files                                                1030     1031       +1     
  Lines                                               17156    17178      +22     
  Branches                                             3124     3129       +5     
==================================================================================
- Hits                                                 7804     7780      -24     
- Misses                                               9352     9398      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 23dbb7b to 11c1f9d Compare December 8, 2025 14:15
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch 2 times, most recently from fd1be9f to 2c6fee8 Compare December 8, 2025 15:21
@Houwie7000 Houwie7000 marked this pull request as ready for review December 9, 2025 14:54
@Houwie7000 Houwie7000 requested a review from graduta as a code owner December 9, 2025 14:54
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 5c9fecd to 950022d Compare December 11, 2025 11:20
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch from 2c6fee8 to 2e50a99 Compare December 11, 2025 11:30
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 950022d to 7f0d22c Compare December 11, 2025 16:20
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch from 2e50a99 to 12144c1 Compare December 11, 2025 16:21
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 7f0d22c to 7628bca Compare December 15, 2025 16:25
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch from 12144c1 to 2982915 Compare December 15, 2025 16:40
@Houwie7000
Copy link
Collaborator Author

Houwie7000 commented Dec 15, 2025

Blocked, found bug in DB logic, sequalize right now refuses to lookup if a value is 0...
Answer, DB stores the duration of 00:00:00 as null not 0. Replacing 0 with null for the query worked

@Houwie7000 Houwie7000 marked this pull request as draft December 15, 2025 16:41
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch from 2982915 to 6f77e0c Compare December 16, 2025 09:36
@Houwie7000 Houwie7000 marked this pull request as ready for review December 16, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants