Skip to content

[O2B-1505] LHCfills beam duration filter #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Houwie7000 wants to merge 45 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feature/O2B-1505/lhcfills-beam-duration-filter

a047600
Select commit
Loading
Failed to load commit list.
Open

[O2B-1505] LHCfills beam duration filter #2035

Merge branch 'main' into feature/O2B-1505/lhcfills-beam-duration-filter
a047600
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2025 in 0s

45.35% (-0.08%) compared to 4d0e2a0

View this Pull Request on Codecov

45.35% (-0.08%) compared to 4d0e2a0

Details

Codecov Report

❌ Patch coverage is 11.53846% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.35%. Comparing base (4d0e2a0) to head (a047600).

Files with missing lines Patch % Lines
...ilters/common/filters/TextComparisonFilterModel.js 0.00% 19 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 12 Missing ⚠️
lib/utilities/validateTime.js 11.11% 8 Missing ⚠️
...nents/Filters/LhcFillsFilter/beamDurationFilter.js 0.00% 4 Missing ⚠️
lib/public/views/Home/Overview/HomePageModel.js 0.00% 1 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
lib/public/views/LhcFills/LhcFills.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   45.43%   45.35%   -0.08%     
==========================================
  Files        1028     1031       +3     
  Lines       17136    17181      +45     
  Branches     3120     3127       +7     
==========================================
+ Hits         7785     7792       +7     
- Misses       9351     9389      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov