-
Notifications
You must be signed in to change notification settings - Fork 482
MathUtils: move BetheBlochAleph to a common header #14918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
The codechecker on ARM seems to complain about more stuff than on X86. |
|
Some of the checks depend on how the code is actually optimised, so that's architecture specific. PR updated with the fix. |
|
@wiechula @davidrohr could you sign off this as TPC? Why was this not part of the common utils? |
|
(or @shahor02, of course) |
davidrohr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I am fiine with this, but why do you keep the BetheBlochAleph.h header with just forwarding the function? I would say we should remove the header completely.
|
To avoid breaking O2Physics. We can clean it up once merged. |
|
Is the error in dataflow: a known issue? |
Yes, I wrote on Mattermost to Sergio and you. It seems the dataflow container was changed, which enabled some GPU tests developed by Matteo. These tests never ran before, since the FullCI has ctests disabled to speed up the build. It seems these tests are generally broken, I tried locally on my system and they are failing as well. #14935 disables them. Not merged yet since I discovered some more tests are failing and I want to get it fully clean. We can merge the BetheBlockAleph PR if you like. |
No description provided.