Skip to content

Conversation

@mrtineide
Copy link
Contributor

@mrtineide mrtineide commented Dec 2, 2025

This changes the HTTP User Agent that is used when accessing CCDB.
The changes come from the libjalienO2 library.

For more details see this merge request.

Waiting for the new tag to be picked up alisw/alidist#6048
It has now been approved

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@mrtineide mrtineide marked this pull request as ready for review December 4, 2025 13:22
@mrtineide mrtineide requested review from a team, Barthelemy, costing and sawenzel as code owners December 4, 2025 13:22
@alibuild
Copy link
Collaborator

alibuild commented Dec 4, 2025

Error while checking build/O2/fullCI_slc9 for ae35002 at 2025-12-09 16:40:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/14884-slc9_x86-64-local2/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[ERROR] Workflow crashed - PID 12680 (HMP-Clusterization) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device HMP-Clusterization: pid 12680 (exit 128)
[ERROR] SEVERE: Device HMP-Clusterization (12680) returned with 128


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/0fad2c365cad3e1725febb5e605c48689982459c/slc9_x86-64/o2checkcode/1.0-local34/etc/modulefiles
++ cat
--

Full log here.

@mrtineide
Copy link
Contributor Author

Is it possible to merge this despite the failing CI?

I can not see how my change and the error can relate at all.

(the error being the libc red black tree re-balance segmentation fault when ROOT Cling processes a macro file finding some ROOT plugin (maybe the zipfile plugin?))

@sawenzel
Copy link
Collaborator

I don't actually know what this is required for. So I would appreciate some more details in the PR message. Is it merely a simplification? What are the consequences for users?

@costing
Copy link
Collaborator

costing commented Dec 10, 2025

It's a common UserAgent string to be used by CCDB calls as well as JAliEn connections. Not important for users, but centrally we'll get a consistent information from both sides, as well as more information encoded in that string than we get today. So it's for us, not for the users.

@mrtineide
Copy link
Contributor Author

I don't actually know what this is required for. So I would appreciate some more details in the PR message.

Apologies for being brief, this PR is about using the new HTTP User Agent string that I made available in libjalien02.
This new User Agent string is to allow for more information in the logs in CCDB. This new string has more information in it, making it easier to track which requests come to CCDB central servers. That is, in the logs in the central servers we have more information.

An example would be

// Old user agent string
b9p02p9794.cern.ch-1764695659-Jb0iA4-3470921716
// example new user agent string
ROOT-Notebook/python3@16946 target/Linux_x86_64 init/1764150428517 id/meide@meide-OptiPlex-7000 session/thaXU7tP  MyDebugSymbol/MyDebugValue

Is it merely a simplification? What are the consequences for users?

There should not be any change in functionality from a users perspective. I guess one change for the users would be a different string in the logs. Also from a users perspective, the username of the user like aliprod, alihyperloop, or local name if testing locally, is also sent.

@sawenzel
Copy link
Collaborator

Thanks for the explanation! I understand much better now.

@sawenzel sawenzel merged commit 7ffc897 into AliceO2Group:dev Dec 10, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants