Skip to content

ITS: GPU: reverse destruction order to fix crash #14863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Nov 27, 2025
Merged

ITS: GPU: reverse destruction order to fix crash #14863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions GPU/GPUTracking/Global/GPUChainITS.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ class GPUFrameworkExternalAllocator final : public o2::its::ExternalAllocator
return mFWReco->AllocateDirectMemory(size, mType);
}
void deallocate(char* ptr, size_t size) final {} // this is a simple no-op
void pushTagOnStack(uint64_t tag)
void pushTagOnStack(uint64_t tag) final
{
mFWReco->PushNonPersistentMemory(tag);
}
void popTagOffStack(uint64_t tag)
void popTagOffStack(uint64_t tag) final
{
mFWReco->PopNonPersistentMemory(GPUDataTypes::RecoStep::ITSTracking, tag);
}
Expand All @@ -45,11 +45,7 @@ class GPUFrameworkExternalAllocator final : public o2::its::ExternalAllocator
};
} // namespace o2::its

GPUChainITS::~GPUChainITS()
{
mITSTrackerTraits.reset();
mITSVertexerTraits.reset();
}
GPUChainITS::~GPUChainITS() = default;

GPUChainITS::GPUChainITS(GPUReconstruction* rec) : GPUChain(rec) {}

Expand Down
6 changes: 3 additions & 3 deletions GPU/GPUTracking/Global/GPUChainITS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class GPUChainITS final : public GPUChain
friend class GPUReconstruction;

public:
~GPUChainITS() override;
~GPUChainITS() final;
int32_t Init() override;
int32_t PrepareEvent() override;
int32_t Finalize() override;
Expand All @@ -50,10 +50,10 @@ class GPUChainITS final : public GPUChain

protected:
GPUChainITS(GPUReconstruction* rec);
std::unique_ptr<o2::its::GPUFrameworkExternalAllocator> mFrameworkAllocator;
std::unique_ptr<o2::its::TimeFrame<7>> mITSTimeFrame;
std::unique_ptr<o2::its::TrackerTraits<7>> mITSTrackerTraits;
std::unique_ptr<o2::its::VertexerTraits<7>> mITSVertexerTraits;
std::unique_ptr<o2::its::TimeFrame<7>> mITSTimeFrame;
std::unique_ptr<o2::its::GPUFrameworkExternalAllocator> mFrameworkAllocator;
};
} // namespace o2::gpu

Expand Down