Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Nov 25, 2025

This is a major change, that improves aod-spawner and brings aod-index-builder to the same level.

  • aod-index-builder is now generic and does not require hardcoding list of tables to build, this is achieved by introducing specific serializable data structure to encode the recipe of building an index table, similar to how aod-spawner was treated before;
  • index table declaration now has a simple sanity check, preventing from using columns that point to tables unrelated to the index table Key;
  • both aod-spawner and aod-index-builder are moved into a plugin;
  • makeEmptyTable now does not use TableBuilder internally and relies on arrow::Table::MakeEmpty;
  • index builder backend was refactored, keeping exactly the same algorithm, but using cleaner helper classes; the code is now out-of-line; the column builders are now allocated only once instead of on every timeframe as before
  • new support features (schema and index recipe serialization) are covered by tests;

@aalkin aalkin requested a review from a team as a code owner November 25, 2025 13:25
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aalkin aalkin requested a review from ktf November 25, 2025 13:29
@ktf ktf merged commit f9d9c0f into AliceO2Group:dev Nov 26, 2025
6 checks passed
@ktf
Copy link
Member

ktf commented Nov 26, 2025

Tested on hyperloop. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants