ITS: GPU: free artefacts from memory after iteration #14815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3sch
requested review from
davidrohr,
fprino,
mconcas and
shahor02
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mconcas
previously approved these changes
Nov 12, 2025
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 502d7ac at 2025-11-12 21:45: Full log here. |
davidrohr
reviewed
Nov 12, 2025
f3sch
force-pushed
the
its/gpu/mclear
branch
from
502d7ac to
2cd9bc1
Compare
Collaborator
Author
|
Now the stack is freed properly after doing a full iteration. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 2cd9bc1 at 2025-11-13 10:58: Full log here. |
Collaborator
Author
|
@davidrohr, the build error seems suspicious but I don't see how it is related to the change here? seems to me that there is some compile definition I have to add to the build command (...I only tested on CUDA...) |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 8835001 at 2025-11-14 12:29: Full log here. |
mconcas
previously approved these changes
Nov 14, 2025
f3sch
commented
Nov 14, 2025
Detectors/ITSMFT/ITS/tracking/include/ITStracking/ExternalAllocator.h
Outdated
Show resolved
Hide resolved
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 5e01540 at 2025-11-17 17:18: Full log here. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
force-pushed
the
its/gpu/mclear
branch
from
5e01540 to
86986f6
Compare
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 86986f6 at 2025-11-19 10:31: Full log here. |
davidrohr
approved these changes
Nov 18, 2025
Collaborator
|
Don't know what is the problem with the 2 CIs, which are not starting. But the PR looks good and all CIs that ran are green, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have to check in detail but seems to work. Did not test the impact on the timing.