Skip to content

DPL: reduce chances to drop offers #14806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Nov 11, 2025
Merged

DPL: reduce chances to drop offers #14806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Framework/Core/include/Framework/ComputingQuotaEvaluator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ComputingQuotaEvaluator
{
public:
// Maximum number of offers this evaluator can hold
static constexpr int MAX_INFLIGHT_OFFERS = 16;
static constexpr int MAX_INFLIGHT_OFFERS = 32;
ComputingQuotaEvaluator(ServiceRegistryRef ref);
/// @a task the task which needs some quota
/// @a request the resource request the @a task needs
Expand Down
2 changes: 1 addition & 1 deletion Framework/Core/include/Framework/ComputingQuotaOffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ using ComputingQuotaRequest = std::function<OfferScore(ComputingQuotaOffer const

/// A consumer is a function which updates a given function removing the
/// amount of resources which are considered as consumed.
using ComputingQuotaConsumer = std::function<void(int id, std::array<ComputingQuotaOffer, 16>&, ComputingQuotaStats&, std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats& stats)>)>;
using ComputingQuotaConsumer = std::function<void(int id, std::array<ComputingQuotaOffer, 32>&, ComputingQuotaStats&, std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats& stats)>)>;

} // namespace o2::framework

Expand Down
2 changes: 1 addition & 1 deletion Framework/Core/src/DataProcessor.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ void DataProcessor::doSend(DataSender& sender, ArrowContext& context, ServiceReg
}
static int64_t previousBytesSent = 0;
auto disposeResources = [bs = context.bytesSent() - previousBytesSent](int taskId,
std::array<ComputingQuotaOffer, 16>& offers,
std::array<ComputingQuotaOffer, 32>& offers,
ComputingQuotaStats& stats,
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
ComputingQuotaOffer disposed;
Expand Down
4 changes: 2 additions & 2 deletions Framework/Core/test/test_ComputingQuotaEvaluator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ TEST_CASE("TestComputingQuotaEvaluator")
};

ComputingQuotaConsumer dispose2MB = [bs = 2000000](int taskId,
std::array<ComputingQuotaOffer, 16>& offers,
std::array<ComputingQuotaOffer, 32>& offers,
ComputingQuotaStats& stats,
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
ComputingQuotaOffer disposed;
Expand All @@ -51,7 +51,7 @@ TEST_CASE("TestComputingQuotaEvaluator")
};

ComputingQuotaConsumer dispose10MB = [bs = 10000000](int taskId,
std::array<ComputingQuotaOffer, 16>& offers,
std::array<ComputingQuotaOffer, 32>& offers,
ComputingQuotaStats& stats,
std::function<void(ComputingQuotaOffer const&, ComputingQuotaStats&)> accountDisposed) {
ComputingQuotaOffer disposed;
Expand Down