Skip to content

Fix protection of MC signal filtering to work with any embedPatt #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Oct 6, 2025
Merged

Fix protection of MC signal filtering to work with any embedPatt #14718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions Detectors/AOD/src/AODProducerWorkflowSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2063,16 +2063,11 @@ void AODProducerWorkflowDPL::run(ProcessingContext& pc)
const auto& mcRecords = mcReader->getDigitizationContext()->getEventRecords();
const auto& mcParts = mcReader->getDigitizationContext()->getEventParts();

// count all parts
int totalNParts = 0;
for (int iCol = 0; iCol < nMCCollisions; iCol++) {
totalNParts += mcParts[iCol].size();

// if signal filtering enabled, let's check if there are more than one source; otherwise fatalise
if (mUseSigFiltMC) {
std::vector<int> sourceIDs{};
auto& colParts = mcParts[iCol];
for (auto colPart : colParts) {
// if signal filtering enabled, let's check if there are more than one source; otherwise fatalise
if (mUseSigFiltMC) {
std::vector<int> sourceIDs{};
for (int iCol = 0; iCol < nMCCollisions; iCol++) {
for (auto const& colPart : mcParts[iCol]) {
int sourceID = colPart.sourceID;
if (std::find(sourceIDs.begin(), sourceIDs.end(), sourceID) == sourceIDs.end()) {
sourceIDs.push_back(sourceID);
Expand All @@ -2081,10 +2076,19 @@ void AODProducerWorkflowDPL::run(ProcessingContext& pc)
break;
}
}
if (sourceIDs.size() <= 1) {
LOGP(fatal, "Signal filtering cannot be enabled without embedding. Please fix the configuration either enabling the embedding, or turning off the signal filtering.");
if (sourceIDs.size() > 1) { // we found more than one, exit
break;
}
}
if (sourceIDs.size() <= 1) {
LOGP(fatal, "Signal filtering cannot be enabled without embedding. Please fix the configuration either enabling the embedding, or turning off the signal filtering.");
}
}

// count all parts
int totalNParts = 0;
for (int iCol = 0; iCol < nMCCollisions; iCol++) {
totalNParts += mcParts[iCol].size();
}
mcCollisionsCursor.reserve(totalNParts);

Expand Down