Skip to content

Add a benchmark for stages of event mixing #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saganatt wants to merge 2 commits into from
Closed

Add a benchmark for stages of event mixing #14705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82c19f
Some fixes to the old mixing benchmark, but it still crashes
saganatt Oct 1, 2025
f3e0120
Add a new benchmark to evaluate the current mixing step-by-step
saganatt Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Framework/Core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ foreach(b
ASoA
ASoAHelpers
EventMixing
EventMixingParts
HistogramRegistry
TableToTree
ExternalFairMQDeviceProxies
Expand Down
132 changes: 120 additions & 12 deletions Framework/Core/test/benchmark_EventMixing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ using namespace o2::soa;
// Validation of new event mixing: time complexity same as for naive loop

#ifdef __APPLE__
constexpr unsigned int maxPairsRange = 5;
constexpr unsigned int maxFivesRange = 3;
constexpr unsigned int maxColPairsRange = 21;
#else
constexpr unsigned int maxPairsRange = 5;
constexpr unsigned int maxFivesRange = 3;
constexpr unsigned int maxColPairsRange = 23;
#endif
constexpr int numEventsToMix = 5;
constexpr int numTracksPerEvent = 10000;
Expand Down Expand Up @@ -66,7 +64,7 @@ static void BM_EventMixingTraditional(benchmark::State& state)
}
auto tableCol = colBuilder.finalize();
o2::aod::Collisions collisions{tableCol};
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size());
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size() - 1);

auto rowWriterTrack = trackBuilder.cursor<o2::aod::StoredTracks>();
for (auto i = 0; i < numTracksPerEvent * state.range(0); ++i) {
Expand All @@ -78,14 +76,14 @@ static void BM_EventMixingTraditional(benchmark::State& state)
auto tableTrack = trackBuilder.finalize();
o2::aod::StoredTracks tracks{tableTrack};

ArrowTableSlicingCache atscache({{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + cutString(getLabelFromType<o2::aod::Collisions>())}});
auto s = atscache.updateCacheEntry(0, tableTrack);
SliceCache cache{&atscache};

int64_t count = 0;
int64_t colCount = 0;
int nBinsTot = (xBins.size() - 2) * (yBins.size() - 2);

ArrowTableSlicingCache atscache({{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + cutString(getLabelFromType<o2::aod::Collisions>())}});
auto s = atscache.updateCacheEntry(0, tableTrack);
SliceCache cache{&atscache};

for (auto _ : state) {
count = 0;
colCount = 0;
Expand Down Expand Up @@ -126,7 +124,7 @@ static void BM_EventMixingTraditional(benchmark::State& state)
state.SetBytesProcessed(state.iterations() * sizeof(float) * count);
}

BENCHMARK(BM_EventMixingTraditional)->RangeMultiplier(2)->Range(4, 8 << maxPairsRange);
BENCHMARK(BM_EventMixingTraditional)->RangeMultiplier(2)->Range(4UL, 2UL << maxColPairsRange);

static void BM_EventMixingCombinations(benchmark::State& state)
{
Expand Down Expand Up @@ -157,7 +155,7 @@ static void BM_EventMixingCombinations(benchmark::State& state)
}
auto tableCol = colBuilder.finalize();
o2::aod::Collisions collisions{tableCol};
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size());
std::uniform_int_distribution<int> uniform_dist_col_ind(0, collisions.size() - 1);

auto rowWriterTrack = trackBuilder.cursor<o2::aod::StoredTracks>();
for (auto i = 0; i < numTracksPerEvent * state.range(0); ++i) {
Expand All @@ -171,6 +169,7 @@ static void BM_EventMixingCombinations(benchmark::State& state)

int64_t count = 0;
int64_t colCount = 0;

ArrowTableSlicingCache atscache{{{getLabelFromType<o2::aod::StoredTracks>(), "fIndex" + getLabelFromType<o2::aod::Collisions>()}}};
auto s = atscache.updateCacheEntry(0, tableTrack);
SliceCache cache{&atscache};
Expand All @@ -196,6 +195,115 @@ static void BM_EventMixingCombinations(benchmark::State& state)
state.SetBytesProcessed(state.iterations() * sizeof(float) * count);
}

BENCHMARK(BM_EventMixingCombinations)->RangeMultiplier(2)->Range(4, 8 << maxPairsRange);
BENCHMARK(BM_EventMixingCombinations)->RangeMultiplier(2)->Range(4UL, 2UL << maxColPairsRange);

static void BM_EventMixingNaiveCollisionsPairsSameCategories(benchmark::State& state)
{
// Seed with a real random value, if available
std::default_random_engine e1(1234567891);
std::uniform_real_distribution<float> uniform_dist(0.f, 1.f);
std::uniform_real_distribution<float> uniform_dist_x(-0.065f, 0.073f);
std::uniform_real_distribution<float> uniform_dist_y(-0.320f, 0.360f);
std::uniform_int_distribution<int> uniform_dist_int(0, 5);

std::vector<double> xBins{VARIABLE_WIDTH, -0.064, -0.062, -0.060, 0.066, 0.068, 0.070, 0.072};
std::vector<double> yBins{VARIABLE_WIDTH, -0.320, -0.301, -0.300, 0.330, 0.340, 0.350, 0.360};
using BinningType = ColumnBinningPolicy<o2::aod::collision::PosX, o2::aod::collision::PosY>;
BinningType binningOnPositions{{xBins, yBins}, true}; // true is for 'ignore overflows' (true by default)

TableBuilder colBuilder;
auto rowWriterCol = colBuilder.cursor<o2::aod::Collisions>();
for (auto i = 0; i < state.range(0); ++i) {
float x = uniform_dist_x(e1);
float y = uniform_dist_y(e1);
rowWriterCol(0, uniform_dist_int(e1),
x, y, uniform_dist(e1),
uniform_dist(e1), uniform_dist(e1), uniform_dist(e1),
uniform_dist(e1), uniform_dist(e1), uniform_dist(e1),
uniform_dist_int(e1), uniform_dist(e1),
uniform_dist_int(e1),
uniform_dist(e1), uniform_dist(e1));
}
auto tableCol = colBuilder.finalize();
o2::aod::Collisions collisions{tableCol};

int64_t colCount = 0;
int nBinsTot = (xBins.size() - 2) * (yBins.size() - 2);

for (auto _ : state) {
colCount = 0;
int n = state.range(0);
std::vector<std::list<o2::aod::Collisions::iterator>> mixingBufferVector;
for (int i = 0; i < nBinsTot; i++) {
mixingBufferVector.push_back(std::list<o2::aod::Collisions::iterator>());
}
for (auto& col1 : collisions) {
int bin = binningOnPositions.getBin({col1.posX(), col1.posY()});
if (bin == -1) {
continue;
}
auto& mixingBuffer = mixingBufferVector[bin];
if (mixingBuffer.size() > 0) {
for (auto& col2 : mixingBuffer) {
colCount++;
}
if (mixingBuffer.size() >= numEventsToMix - 1) {
mixingBuffer.pop_back();
}
}
mixingBuffer.push_front(col1);
}
benchmark::DoNotOptimize(colCount);
}
state.counters["Mixed collision pairs"] = colCount;
state.SetBytesProcessed(state.iterations() * sizeof(float) * colCount);
}

BENCHMARK(BM_EventMixingNaiveCollisionsPairsSameCategories)->RangeMultiplier(2)->Range(4UL, 2UL << maxColPairsRange);

static void BM_EventMixingCombGenCollisionsPairsSameCategories(benchmark::State& state)
{
// Seed with a real random value, if available
std::default_random_engine e1(1234567891);
std::uniform_real_distribution<float> uniform_dist(0.f, 1.f);
std::uniform_real_distribution<float> uniform_dist_x(-0.065f, 0.073f);
std::uniform_real_distribution<float> uniform_dist_y(-0.320f, 0.360f);
std::uniform_int_distribution<int> uniform_dist_int(0, 5);

std::vector<double> xBins{VARIABLE_WIDTH, -0.064, -0.062, -0.060, 0.066, 0.068, 0.070, 0.072};
std::vector<double> yBins{VARIABLE_WIDTH, -0.320, -0.301, -0.300, 0.330, 0.340, 0.350, 0.360};
using BinningType = ColumnBinningPolicy<o2::aod::collision::PosX, o2::aod::collision::PosY>;
BinningType binningOnPositions{{xBins, yBins}, true}; // true is for 'ignore overflows' (true by default)

TableBuilder colBuilder;
auto rowWriterCol = colBuilder.cursor<o2::aod::Collisions>();
for (auto i = 0; i < state.range(0); ++i) {
float x = uniform_dist_x(e1);
float y = uniform_dist_y(e1);
rowWriterCol(0, uniform_dist_int(e1),
x, y, uniform_dist(e1),
uniform_dist(e1), uniform_dist(e1), uniform_dist(e1),
uniform_dist(e1), uniform_dist(e1), uniform_dist(e1),
uniform_dist_int(e1), uniform_dist(e1),
uniform_dist_int(e1),
uniform_dist(e1), uniform_dist(e1));
}
auto tableCol = colBuilder.finalize();
o2::aod::Collisions collisions{tableCol};

int64_t colCount = 0;

for (auto _ : state) {
colCount = 0;
for (auto& comb : combinations(CombinationsBlockUpperSameIndexPolicy(binningOnPositions, numEventsToMix - 1, -1, collisions, collisions))) {
colCount++;
}
benchmark::DoNotOptimize(colCount);
}
state.counters["Mixed collision pairs"] = colCount;
state.SetBytesProcessed(state.iterations() * sizeof(float) * colCount);
}

BENCHMARK(BM_EventMixingCombGenCollisionsPairsSameCategories)->RangeMultiplier(2)->Range(4UL, 2UL << maxColPairsRange);

BENCHMARK_MAIN();
Loading