DPL: refactor TransitionState calculation #14701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Member
Author
|
@ehellbar this is what we discussed today. Still to be tested. |
Collaborator
Collaborator
|
Hi @ktf , thank you for this. I tested it locally with test workflows, all good. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 5dafde5 at 2025-10-21 00:38: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 9b2f2c1 at 2025-10-29 17:28: Full log here. |
The executable might be in some subfolder, like stage/bin/.
* Drop unneeded helper. * Move the policies to the DeviceContext
Move it to a function and make it easily invokable with just a service registry ref. This should not change the current behavior. The goal is to be able to trigger the timers also within the input proxy busy loop so that the timers start at the appropriate moment.
Member
Author
|
@ehellbar as discussed private I understood the issue (the old instance for the processing policies was not removed and it was getting accessed uninitialised) and fixed it. The rest is otherwise unchanged and therefore I am merging this. Can you take a stab at integrating it with the input proxy? We have a look together if you want tomorrow if there is any issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move it to a function and make it easily invokable with just a service registry ref.
This should not change the current behavior.
The goal is to be able to trigger the timers also within the input proxy busy loop so
that the timers start at the appropriate moment.