Skip to content

Add possibility to apply signal filtering for MC with embedding #14698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 4 commits into from
Sep 30, 2025
Merged

Add possibility to apply signal filtering for MC with embedding #14698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a1dd9e
Add possibility to apply signal filtering for MC with embedding
fgrosa Sep 26, 2025
860a869
Please consider the following formatting changes
alibuild Sep 26, 2025
35c4cb6
Merge pull request #24 from alibuild/alibot-cleanup-14698
fgrosa Sep 26, 2025
e0338e4
Add protection for signal filtering to be enabled only with emdedding
fgrosa Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Detectors/AOD/include/AODProducerWorkflow/AODProducerWorkflowSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ class AODProducerWorkflowDPL : public Task

int mNThreads = 1;
bool mUseMC = true;
bool mUseSigFiltMC = false; // enable signal filtering for MC with embedding
bool mEnableSV = true; // enable secondary vertices
bool mEnableFITextra = false;
bool mFieldON = false;
Expand Down
44 changes: 35 additions & 9 deletions Detectors/AOD/src/AODProducerWorkflowSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,13 +947,17 @@ void clearMCKeepStore(std::vector<std::vector<std::unordered_map<int, int>>>& st
}

// helper function to add a particle/track to the MC keep store
void keepMCParticle(std::vector<std::vector<std::unordered_map<int, int>>>& store, int source, int event, int track, int value = 1)
void keepMCParticle(std::vector<std::vector<std::unordered_map<int, int>>>& store, int source, int event, int track, int value = 1, bool useSigFilt = false)
{
if (track < 0) {
LOG(warn) << "trackID is smaller than 0. Neglecting";
return;
}
store[source][event][track] = value;
if (useSigFilt && source == 0) {
store[source][event][track] = -1;
} else {
store[source][event][track] = value;
}
}

void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader& mcReader,
Expand Down Expand Up @@ -982,7 +986,7 @@ void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader&
if (!mcLabel.isValid()) {
return;
}
keepMCParticle(mToStore, mcLabel.getSourceID(), mcLabel.getEventID(), mcLabel.getTrackID());
keepMCParticle(mToStore, mcLabel.getSourceID(), mcLabel.getEventID(), mcLabel.getTrackID(), 1, mUseSigFiltMC);
};

// mark reconstructed MC particles to store them into the table
Expand All @@ -997,7 +1001,7 @@ void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader&
if (!mcTruth.isValid()) {
continue;
}
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID());
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID(), 1, mUseSigFiltMC);
// treating contributors of global tracks
auto contributorsGID = data.getSingleDetectorRefs(trackIndex);
if (contributorsGID[GIndex::Source::TPC].isIndexSet()) {
Expand All @@ -1012,7 +1016,7 @@ void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader&
if (!mcLabel.isValid()) {
continue;
}
keepMCParticle(mToStore, mcLabel.getSourceID(), mcLabel.getEventID(), mcLabel.getTrackID());
keepMCParticle(mToStore, mcLabel.getSourceID(), mcLabel.getEventID(), mcLabel.getTrackID(), 1, mUseSigFiltMC);
}
}
}
Expand All @@ -1026,7 +1030,7 @@ void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader&
if (!mcTruth.isValid()) {
continue;
}
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID());
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID(), 1, mUseSigFiltMC);
}
}
if (mInputSources[GIndex::PHS]) {
Expand All @@ -1035,7 +1039,7 @@ void AODProducerWorkflowDPL::fillMCParticlesTable(o2::steer::MCKinematicsReader&
if (!mcTruth.isValid()) {
continue;
}
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID());
keepMCParticle(mToStore, mcTruth.getSourceID(), mcTruth.getEventID(), mcTruth.getTrackID(), 1, mUseSigFiltMC);
}
}
using namespace aodmchelpers;
Expand Down Expand Up @@ -1728,6 +1732,8 @@ void AODProducerWorkflowDPL::init(InitContext& ic)
LOG(info) << "The Run number will be obtained from DPL headers";
}

mUseSigFiltMC = ic.options().get<bool>("mc-signal-filt");

// set no truncation if selected by user
if (mTruncate != 1) {
LOG(info) << "Truncation is not used!";
Expand Down Expand Up @@ -2046,6 +2052,24 @@ void AODProducerWorkflowDPL::run(ProcessingContext& pc)
int totalNParts = 0;
for (int iCol = 0; iCol < nMCCollisions; iCol++) {
totalNParts += mcParts[iCol].size();

// if signal filtering enabled, let's check if there are more than one source; otherwise fatalise
if (mUseSigFiltMC) {
std::vector<int> sourceIDs{};
auto& colParts = mcParts[iCol];
for (auto colPart : colParts) {
int sourceID = colPart.sourceID;
if (std::find(sourceIDs.begin(), sourceIDs.end(), sourceID) == sourceIDs.end()) {
sourceIDs.push_back(sourceID);
}
if (sourceIDs.size() > 1) { // we found more than one, exit
break;
}
}
if (sourceIDs.size() <= 1) {
LOGP(fatal, "Signal filtering cannot be enabled without embedding. Please fix the configuration either enabling the embedding, or turning off the signal filtering.");
}
}
}
mcCollisionsCursor.reserve(totalNParts);

Expand Down Expand Up @@ -2083,7 +2107,9 @@ void AODProducerWorkflowDPL::run(ProcessingContext& pc)
0,
sourceID);
}
mcColToEvSrc.emplace_back(std::vector<int>{iCol, sourceID, eventID}); // point background and injected signal events to one collision
if (sourceID != 0 || !mUseSigFiltMC) {
mcColToEvSrc.emplace_back(std::vector<int>{iCol, sourceID, eventID}); // point background and injected signal events to one collision
}
}
}
}
Expand Down Expand Up @@ -3311,7 +3337,7 @@ DataProcessorSpec getAODProducerWorkflowSpec(GID::mask_t src, bool enableSV, boo
ConfigParamSpec{"trackqc-tpc-pt", VariantType::Float, 0.2f, {"Keep TPC standalone track with this pt"}},
ConfigParamSpec{"with-streamers", VariantType::String, "", {"Bit-mask to steer writing of intermediate streamer files"}},
ConfigParamSpec{"seed", VariantType::Int, 0, {"Set seed for random generator used for sampling (0 (default) means using a random_device)"}},
}};
ConfigParamSpec{"mc-signal-filt", VariantType::Bool, false, {"Enable usage of signal filtering (only for MC with embedding)"}}}};
}

} // namespace o2::aodproducer