Refactor: IRIS tracker geometry (ALICE 3) #14693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Contributor
|
Hello @plariono, thanks! Regarding the rectangular L0, at the moment the digitizer does not foresee rectangular layers in the VD, and some methods to deal with the curved layers are automatically called. I will have to add a check for the different iris versions in the digitizer to deal with this. |
Contributor
Author
|
Hi @atriolo, thank you, I'll check the workflow command. |
Contributor
|
@plariono yes indeed, a getter which returns the type of layer or something like this would be optimal, so I can check this variable before applying the methods for the curved layers. We can discuss about it if you want. Thanks! |
Contributor
Author
|
@atriolo sure, let's discuss tomorrow. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 3972075 at 2025-10-20 11:42: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 251e27e at 2025-10-22 04:37: Full log here. |
(cherry picked from commit d291e57a2f121c4f19f1fb7ccd8031328abc9ce8)
plariono
requested review from
a team,
arossi81,
davidrohr,
f3sch,
fgrosa,
fprino,
jackal1-66,
kharlov,
noferini,
peressounko,
sawenzel,
shahor02 and
wiechula
as code owners
plariono
requested review from
a team,
afurs,
andreasmolander,
iarsene,
jokonig,
jotwinow,
matthiasrichter,
maxrauch and
nstrangm
as code owners
plariono
force-pushed
the
refactor-iris-geom
branch
from
8a3ddd1 to
fd37c37
Compare
Collaborator
|
Hi @plariono. This PR seems to touch many files which are not related to the changes you mentioned, including e.g. FOCAL simcuts. Maybe you need to rebase? |
Contributor
Author
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 424857b at 2025-10-23 12:47: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 3c6fbd5 at 2025-10-23 13:35: Full log here. |
njacazio
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new version of the IRIS tracker geometry for the ALICE3 TRK.
Changes
VDLayerhierarchy:VDCylindricalLayer,VDRectangularLayer,VDDiskLayercreateLayer()/createSensor()methods.createIRIS4Geometry(),createIRIS5Geometry(),createIRIS3Geometry()Detector.cxx:VDGeometryBuilder.Benefits
IRIS4,IRIS4a,IRIS5).@atriolo I kept for the moment the existing sensor naming as
PETALCASE#_LAYER#_TRKSensor#. I don't know if there are some unit test that I could run to check if the digitiser is working properly, could you suggest if there are any? Also curious to know how would the rectangular L0 would be treated as it is not curved.