Skip to content

Conversation

@shahor02
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@shahor02
Copy link
Collaborator Author

@miranov25 , the TRD tracklet slopes can be checked via

unbinnedRes->Draw("tracks.TRDTrkltSlope*5./0x7fff","tracks.TRDTrkltSlope!=0");

@miranov25
Copy link
Contributor

Hello @shahor02,

Thanks for the update. I see we currently use short; we could switch to char (and similarly for other TrackData fields), but I’m unsure about backward/forward compatibility with existing data/readers. I’ve run into readback issues after similar changes before, so perhaps we should keep short for now.

Otherwise, the change is exactly what I had in mind. Have you produced a sample so I can verify the content?

Regards,
Marian

@shahor02
Copy link
Collaborator Author

@miranov25, here is pp data:

/alice/cern.ch/user/s/shahoian/toMI/o2tpc_residuals_1746914568173_1746915768168_421705_843409.root 

@miranov25
Copy link
Contributor

Hello @shahor02,

I’m running into a forward-compatibility problem: my code can’t draw your new data even though the branch exists.

root [19] trackData->Draw("trk.TRDTrkltSlope","")
(long long) 0

TRDTrkltSlope is present in the tree, but Draw returns zero entries. I’ve seen similar behavior before when schema/layout changes break older readers. Interesting that in the past we did not have issue reading arbitrary branch of the tree

If it works on your side, please go ahead and merge. I’ll then test against master and verify the values.

In particular, I want to compare the angle to GetSnp at the reference radius, to test tracklet angle cut.

I assume cut will be :|
Ntracklet>Ntracklet findable -1

Best,
Marian

@shahor02
Copy link
Collaborator Author

Please try again, the class version was not incremented

@shahor02 shahor02 merged commit f2e0f3d into AliceO2Group:dev Sep 16, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants