Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Sep 15, 2025

This adds some testing to the configurable keys code, requiring its own ConfigurableParam o2::conf::test::TestParam which is only built if tests are built. Testing is done for setting/getting/serialziation/deserialization.
Also this adds accepting literal suffixes for fundamental types to the setting the values from a string, e.g. allowing for "TestParam.fValue=42.f" which previously failed (I have fallen for this already a couple of times since its is easy to overlook the error in the many log messages we produce).

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review September 15, 2025 07:44
@f3sch f3sch requested a review from sawenzel as a code owner September 15, 2025 07:44
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 9507a78 at 2025-09-15 11:36:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/85a1a241a1e7ca1211c355dbdfd832217b2b0126/slc9_x86-64/o2checkcode/1.0-local539/etc/modulefiles
++ cat
--

Full log here.

@sawenzel sawenzel merged commit cec632f into AliceO2Group:dev Sep 26, 2025
13 checks passed
@f3sch f3sch deleted the confkey/literalsuffix branch September 26, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants