Skip to content

Conversation

@mhemmer-cern
Copy link
Contributor

  • The macro PROCESS_SWITCH and PROCESS_SWITCH_FULL required one to use using namespace o2::framework otherwise one would get Use of undeclared identifier 'ProcessConfigurable' since macros are expanded as plain text and do not see any namespace that they might be living in. This PR should fix this behavior by explicitly using the namespace in the macro definition.

- The macro `PROCESS_SWITCH` and `PROCESS_SWITCH_FULL` required one to use `using namespace o2::framework` otherwise one would get `Use of undeclared identifier 'ProcessConfigurable'`. This PR should fix this behaviour by explicitly using the namepsace in the macro definition.
@mhemmer-cern mhemmer-cern requested a review from a team as a code owner September 12, 2025 09:11
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@mhemmer-cern
Copy link
Contributor Author

This is not needed for any reconstruction.

@ktf
Copy link
Member

ktf commented Sep 15, 2025

Makes sense to me. @aalkin ?

@aalkin
Copy link
Member

aalkin commented Sep 15, 2025

@ktf yes, indeed, macros should use fully-qualified names. In principle, with c++20 we also should be able to do something like auto pc = o2::framework::ProcessConfigurable{&Task::someProcess, "someProcess", false, "some process function"}; directly without the need for the macro.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 7d055bb at 2025-09-16 13:51:

No log files found

Full log here.

@mhemmer-cern
Copy link
Contributor Author

So can this be merged?

@ktf ktf merged commit 28eb74a into AliceO2Group:dev Sep 21, 2025
11 of 12 checks passed
@ktf
Copy link
Member

ktf commented Sep 21, 2025

yes, sorry i missed it...

@mhemmer-cern mhemmer-cern deleted the fix-PROCESS_SWITCH-macro branch September 21, 2025 20:05
@mhemmer-cern
Copy link
Contributor Author

yes, sorry i missed it...

Ah okay, no worries.
Thank you for the merge now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants