-
Notifications
You must be signed in to change notification settings - Fork 483
Add ITS fake clusters information to the mcMask #14666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just 1 comment below.
| } | ||
| if (trackIndex.includesDet(DetID::ITS)) { | ||
| auto itsGID = data.getITSContributorGID(trackIndex); | ||
| if (itsGID.isIndexSet()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is not needed, if trackIndex.includesDet(DetID::ITS) is true, then the itsGID.isIndexSet() is guaranteed.
Just check
if (itsGID.getSource() == GIndex::ITS) {
... as ITS track
} else {
... as AB track
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ! Fixed
|
Hi @shahor02, can we merge this if it looks good, thanks. |
* Add ITS fake clusters information to the mcMask * remove redundant check --------- Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
BITS 0-6 were not set, in contrary to what was stated in the mcMask description in
AnalysisDataModel.h.I also added a bit to account for fake AB ITS tracklets (BIT 12) and fixed the description of the last three bits in
AnalysisDataModel.hCould you please have a look?
@shahor02 @jgrosseo @ddobrigk