Skip to content

GPU TPC: Make buffer size estimation more robust #14665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Sep 10, 2025
+11 −2
Merged

GPU TPC: Make buffer size estimation more robust #14665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f35cf5
GPU TPC: Make buffer size estimation more robust and improve error me…
davidrohr Sep 9, 2025
20bb190
GPU TPC dEdx: Fix out of bounds access
davidrohr Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions GPU/GPUTracking/SectorTracker/GPUTPCTracker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,15 @@ void GPUTPCTracker::SetMaxData(const GPUTrackingInOutPointers& io)
mNMaxTracklets = mRec->MemoryScalers()->NTPCTracklets(mData.NumberOfHits());
mNMaxRowHits = mRec->MemoryScalers()->NTPCTrackletHits(mData.NumberOfHits());
mNMaxTracks = mRec->MemoryScalers()->NTPCSectorTracks(mData.NumberOfHits());
if (io.clustersNative) {
uint32_t sectorOffset = mISector >= GPUCA_NSECTORS / 2 ? GPUCA_NSECTORS / 2 : 0;
uint32_t nextSector = (mISector + 1) % (GPUCA_NSECTORS / 2) + sectorOffset;
uint32_t prevSector = (mISector + GPUCA_NSECTORS - 1) % (GPUCA_NSECTORS / 2) + sectorOffset;
uint32_t nExtrapolationTracks = mRec->MemoryScalers()->NTPCSectorTracks((io.clustersNative->nClustersSector[nextSector] + io.clustersNative->nClustersSector[prevSector]) / 2) / 2;
if (nExtrapolationTracks > mNMaxTracks) {
mNMaxTracks = nExtrapolationTracks;
}
}
mNMaxTrackHits = mRec->MemoryScalers()->NTPCSectorTrackHits(mData.NumberOfHits(), mRec->GetProcessingSettings().tpcInputWithClusterRejection);

if (mRec->getGPUParameters(mRec->GetRecoStepsGPU() & GPUDataTypes::RecoStep::TPCSectorTracking).par_SORT_STARTHITS) {
Expand Down
2 changes: 1 addition & 1 deletion GPU/GPUTracking/dEdx/GPUdEdx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ GPUdnii() void GPUdEdx::fillCluster(float qtot, float qmax, int32_t padRow, uint
const float tanTheta = CAMath::Sqrt(tgl2 * sec2);

// getting the topology correction
const uint32_t padPos = CAMath::Float2UIntRn(pad); // position of the pad is shifted half a pad ( pad=3 -> centre position of third pad)
const uint32_t padPos = CAMath::Max<uint32_t>(GPUTPCGeometry::NPads(padRow) - 1, CAMath::Float2UIntRn(pad)); // position of the pad is shifted half a pad ( pad=3 -> centre position of third pad)
const float absRelPad = CAMath::Abs(pad - padPos);
const int32_t region = geo.GetRegion(padRow);
z = CAMath::Abs(z);
Expand Down
2 changes: 1 addition & 1 deletion GPU/Workflow/src/GPUWorkflowSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ void GPURecoWorkflowSpec::run(ProcessingContext& pc)
}
createEmptyOutput = !mConfParam->partialOutputForNonFatalErrors;
} else {
throw std::runtime_error("GPU Reconstruction error: error code " + std::to_string(retVal));
LOG(fatal) << "GPU Reconstruction aborted with error code " << retVal << " - errors are not ignored - terminating";
}
}

Expand Down