Skip to content

[Common] Add eta, omega and eta' to PhysicsConstants.h #14662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 1 commit into from
Oct 10, 2025
Merged

[Common] Add eta, omega and eta' to PhysicsConstants.h #14662

shahor02 merged 1 commit into from
Oct 10, 2025

Conversation

@mhemmer-cern
Copy link
Contributor

@mhemmer-cern mhemmer-cern commented Sep 9, 2025 •
edited
Loading

  • Add eta, omega and etaPrime meson to the PhysicsConstants.h with PDG value and mass since they are missing here and are not defined in ROOTs TPDGCode.h by updating make_pdg_header.py and running the script and copying the output to the header file

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@mhemmer-cern
Copy link
Contributor Author

mhemmer-cern commented Sep 9, 2025 •
edited
Loading

Since this is just addition of some physics constants it is not needed in any reconstruction and only really relevant for clean analysis code in O2Physics.

@mhemmer-cern mhemmer-cern changed the title [Common] Add eta and eta' to PhysicsConstants.h [Common] Add eta, omega and eta' to PhysicsConstants.h Sep 9, 2025
@mhemmer-cern mhemmer-cern marked this pull request as draft September 9, 2025 13:38
@alibuild
Copy link
Collaborator

alibuild commented Sep 9, 2025

Error while checking build/O2/fullCI_slc9 for cb336fb at 2025-09-09 16:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:272:41: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:278:41: error: reference to 'kEtaPrime' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:306:41: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:318:41: error: reference to 'kEtaPrime' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:340:14: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:343:14: error: reference to 'kEtaPrime' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:375:35: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:381:35: error: reference to 'kEtaPrime' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/Tasks/taskSingleElectron.cxx:338:50: error: could not convert '{{kPi0, Pi0}, {<expression error>, Eta}, {kOmega, Omega}, {o2::constants::physics::kPhi, Phi}, {<expression error>, EtaPrime}, {kRho770_0, Rho0}, {kKPlus, Ke3}, {kK0Long, K0l}}' from '<brace-enclosed initializer list>' to 'const std::map<int, SourceType>'
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx:572:45: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx:582:51: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx:590:54: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx:597:54: error: reference to 'kEta' is ambiguous
/sw/SOURCES/O2Physics/14662-slc9_x86-64/0/PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx:604:57: error: reference to 'kEta' is ambiguous
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/345521b3820f123fbc3954339692730de60e22a8/slc9_x86-64/o2checkcode/1.0-local916/etc/modulefiles
++ cat
--

Full log here.

@vkucera vkucera self-requested a review September 9, 2025 14:24
@mhemmer-cern
[Common] Add eta, omega and eta' to PhysicsConstants.h
8751a56 
- Add eta, omega and etaPrime meson to the PhysicsConstants.h with PDG value and mass by updating make_pdg_header.py and running the script and copying the output to the header file.
@vkucera vkucera marked this pull request as ready for review September 9, 2025 14:36
@mhemmer-cern
Copy link
Contributor Author

mhemmer-cern commented Sep 9, 2025

I guess this should not be merged before changes are made in O2Physics to ensure that there are no problems with O2Physics compilation.
Once a PR for O2Physics is made I will link it here.

@vkucera
Copy link
Collaborator

vkucera commented Sep 9, 2025

I guess this should not be merged before changes are made in O2Physics to ensure that there are no problems with O2Physics compilation. Once a PR for O2Physics is made I will link it here.

True. Converting to draft until then.

@vkucera vkucera marked this pull request as draft September 9, 2025 15:12
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Sep 12, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
db08825 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Sep 12, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
7289780 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
d419eb9 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
c5b335e 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
a5672f0 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
abe1a73 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
@mhemmer-cern mhemmer-cern mentioned this pull request Oct 7, 2025
Merged
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
4a0095b 
PWGHF: Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.
PWGEM:
  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.
Trigger: Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
fc13e9d 
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.

  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.

- Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
88bad87 
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.

  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.

- Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
f27e6a3 
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.

  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.

- Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
dd9fc6c 
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.

  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.

- Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
mhemmer-cern added a commit to mhemmer-cern/O2Physics that referenced this pull request Oct 7, 2025
@mhemmer-cern
[PWGEM,PWGHF,Trigger] Fix O2linter warnings
a674e4f 
- Preparation for AliceO2Group/AliceO2#14662 where eta, omega and etaPrime are added to the `PhysicsConstants.h` which clasehd with some local enum definitions here.

  1. Removal of `using` in some header files and necessary changes because of this removal (EventFiltering for example)
  2. Cleaning up includes in most touched files here after the removal of `using`
  3. PI from match constanst, naming of some variables and other O2 Linter errors. Changes to configurable names were not done since this would mess up all ongoing analyses wagons.
  4. Addition of new task for EMCal cluster energy calibration. For high mult AA collisions the cluster energy needs some extra calibration, since a single cluster often has energy deposition from more than just the photon that we are interested in. To correct for this enhancement in cluster energy this task should provide the neccesary output to create a correction for it.

- Fix includes and added [[maybe_unused]] to some local variables that are used as inital parameters for configurables to silence compiler warnings/clangd. Add comment for explanation of this change as well.
@mhemmer-cern
Copy link
Contributor Author

mhemmer-cern commented Oct 8, 2025

Since AliceO2Group/O2Physics#13264 is merged now I guess we just need to wait like 1 or 2 days for Cl to pick it up and this can be build again merged than? @ktf

@mhemmer-cern mhemmer-cern marked this pull request as ready for review October 9, 2025 09:31
@alibuild
Copy link
Collaborator

alibuild commented Oct 9, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 8751a56 at 2025-10-09 19:17:

No log files found

Full log here.

@mhemmer-cern
Copy link
Contributor Author

mhemmer-cern commented Oct 10, 2025

Can this be merged please @shahor02 ?

@shahor02 shahor02 merged commit a662980 into AliceO2Group:dev Oct 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

@vkucera vkucera vkucera approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhemmer-cern @alibuild @vkucera @shahor02