Skip to content

DPL: initial metric to debug size of the histograms / objects being written #14636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Aug 30, 2025
Merged

DPL: initial metric to debug size of the histograms / objects being written #14636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Framework/AnalysisSupport/src/AODWriterHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
#include "Framework/TableConsumer.h"
#include "Framework/DataOutputDirector.h"
#include "Framework/TableTreeHelpers.h"
#include "Framework/Monitoring.h"

#include <Monitoring/Monitoring.h>
#include <TFile.h>
#include <TFile.h>
#include <TTree.h>
Expand Down Expand Up @@ -235,6 +237,7 @@ AlgorithmSpec AODWriterHelpers::getOutputTTreeWriter(ConfigContext const& ctx)

AlgorithmSpec AODWriterHelpers::getOutputObjHistWriter(ConfigContext const& ctx)
{
using namespace monitoring;
auto& ac = ctx.services().get<AnalysisContext>();
auto tskmap = ac.outTskMap;
auto objmap = ac.outObjHistMap;
Expand Down Expand Up @@ -269,7 +272,7 @@ AlgorithmSpec AODWriterHelpers::getOutputObjHistWriter(ConfigContext const& ctx)

callbacks.set<CallbackService::Id::EndOfStream>(endofdatacb);
return [inputObjects, objmap, tskmap](ProcessingContext& pc) mutable -> void {
auto mergePart = [&inputObjects, &objmap, &tskmap](DataRef const& ref) {
auto mergePart = [&inputObjects, &objmap, &tskmap, &pc](DataRef const& ref) {
if (!ref.header) {
LOG(error) << "Header not found";
return;
Expand Down Expand Up @@ -381,7 +384,13 @@ AlgorithmSpec AODWriterHelpers::getOutputObjHistWriter(ConfigContext const& ctx)
if (object->InheritsFrom(TList::Class())) {
writeListToFile(static_cast<TList*>(object), parentDir->mkdir(object->GetName(), object->GetName(), true));
} else {
parentDir->WriteObjectAny(object, object->Class(), object->GetName());
int objSize = parentDir->WriteObjectAny(object, object->Class(), object->GetName());
static int maxSizeWritten = 0;
if (objSize > maxSizeWritten) {
auto& monitoring = pc.services().get<Monitoring>();
maxSizeWritten = objSize;
monitoring.send(Metric{fmt::format("{}/{}:{}", object->ClassName(), object->GetName(), objSize), "aod-largest-object-written"}.addTag(tags::Key::Subsystem, tags::Value::DPL));
}
auto* written = list->Remove(object);
delete written;
}
Expand Down
1 change: 1 addition & 0 deletions Framework/Core/src/runDataProcessing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,7 @@ std::vector<std::regex> getDumpableMetrics()
dumpableMetrics.emplace_back("^aod-bytes-read-uncompressed$");
dumpableMetrics.emplace_back("^aod-bytes-read-compressed$");
dumpableMetrics.emplace_back("^aod-file-read-info$");
dumpableMetrics.emplace_back("^aod-largest-object-written$");
dumpableMetrics.emplace_back("^table-bytes-.*");
dumpableMetrics.emplace_back("^total-timeframes.*");
dumpableMetrics.emplace_back("^device_state.*");
Expand Down