Skip to content

Ctpdev: validity of orbitreset #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 3 commits into from
Aug 24, 2025
Merged

Ctpdev: validity of orbitreset #14612

shahor02 merged 3 commits into from
Aug 24, 2025
+9 −6

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Aug 22, 2025

Fix of resetorbit validity adjutment (missed in the previous validity PR)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lietava lietava marked this pull request as ready for review August 22, 2025 13:07
@lietava lietava requested a review from a team as a code owner August 22, 2025 13:07
@lietava
Copy link
Contributor Author

lietava commented Aug 23, 2025

@shahor02 , plese, merge.
This is orbitreset validity - last time I did not change it in the all necessary parts. So it will start only after this fix.

shahor02
shahor02 reviewed Aug 23, 2025
View reviewed changes
Detectors/CTP/workflowScalers/src/ctpCCDBManager.cxx Outdated
auto ti = tcls->GetTypeInfo();
auto classname = "std::vector<int64_t>";
metadata["adjustableEOV"] = "true";
int ret = api.storeAsTFile_impl(&(vect), *ti, mCCDBPathOrbitReset, metadata, tmin, tmax);
Copy link
Collaborator

@shahor02 shahor02 Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are using storeAsTFile_impl? Please use the standard interface api.storeAsTFile(...

Copy link
Contributor Author

@lietava lietava Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied how I did it at:PR14534

Should I change to storeAsTFileAny(... or storeAsTFile(... ?

Copy link
Collaborator

@shahor02 shahor02 Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use storeAsTFileAny, the .._impl is an implementation which may change.

@lietava
Copy link
Contributor Author

lietava commented Aug 24, 2025

@shahor02 , please, merge

@shahor02 shahor02 merged commit d823a46 into AliceO2Group:dev Aug 24, 2025
12 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@lietava @mhemmer-cern
Ctpdev: validity of orbitreset (AliceO2Group#14612)
147e970 
* dev: validity range adjustment

* clang

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lietava @shahor02