Skip to content

GPU Workflow: Disabled unneeded stuff if ITS / Thread-Pipeline disabled #14611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Aug 25, 2025
Merged

GPU Workflow: Disabled unneeded stuff if ITS / Thread-Pipeline disabled #14611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21bb7f4
GPU Workflow: Don't load ITS geometry when ITS is not used
davidrohr Aug 20, 2025
5c16175
GPU Workflow: Do not do calib requests / updates in gpu-reconstructio…
davidrohr Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GPU/Workflow/src/GPUWorkflowPipeline.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ int32_t GPURecoWorkflowSpec::handlePipeline(ProcessingContext& pc, GPUTrackingIn
ptrs.tpcZS = &tpcZS;
}
if (mSpecConfig.enableDoublePipeline == 2) {
auto prepareBuffer = pc.outputs().make<DataAllocator::UninitializedVector<char>>(Output{gDataOriginGPU, "PIPELINEPREPARE", 0}, 0u);
auto prepareDummyMessage = pc.outputs().make<DataAllocator::UninitializedVector<char>>(Output{gDataOriginGPU, "PIPELINEPREPARE", 0}, 0u);

size_t ptrsTotal = 0;
const void* firstPtr = nullptr;
Expand Down
82 changes: 43 additions & 39 deletions GPU/Workflow/src/GPUWorkflowSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,11 +613,13 @@ void GPURecoWorkflowSpec::run(ProcessingContext& pc)
auto lockDecodeInput = std::make_unique<std::lock_guard<std::mutex>>(mPipeline->mutexDecodeInput);

GRPGeomHelper::instance().checkUpdates(pc);
if (pc.inputs().getPos("itsTGeo") >= 0) {
pc.inputs().get<o2::its::GeometryTGeo*>("itsTGeo");
}
if (GRPGeomHelper::instance().getGRPECS()->isDetReadOut(o2::detectors::DetID::TPC) && mConfParam->tpcTriggeredMode ^ !GRPGeomHelper::instance().getGRPECS()->isDetContinuousReadOut(o2::detectors::DetID::TPC)) {
LOG(fatal) << "configKeyValue tpcTriggeredMode does not match GRP isDetContinuousReadOut(TPC) setting";
if (mSpecConfig.enableDoublePipeline != 2) {
if (mSpecConfig.runITSTracking && pc.inputs().getPos("itsTGeo") >= 0) {
pc.inputs().get<o2::its::GeometryTGeo*>("itsTGeo");
}
if (GRPGeomHelper::instance().getGRPECS()->isDetReadOut(o2::detectors::DetID::TPC) && mConfParam->tpcTriggeredMode ^ !GRPGeomHelper::instance().getGRPECS()->isDetContinuousReadOut(o2::detectors::DetID::TPC)) {
LOG(fatal) << "configKeyValue tpcTriggeredMode does not match GRP isDetContinuousReadOut(TPC) setting";
}
}

GPUTrackingInOutPointers ptrs;
Expand All @@ -630,23 +632,25 @@ void GPURecoWorkflowSpec::run(ProcessingContext& pc)
mTFSettings->hasNHBFPerTF = 1;
mTFSettings->nHBFPerTF = mConfParam->overrideNHbfPerTF ? mConfParam->overrideNHbfPerTF : GRPGeomHelper::instance().getGRPECS()->getNHBFPerTF();
mTFSettings->hasRunStartOrbit = 0;
if (mVerbosity) {
LOG(info) << "TF firstTForbit " << mTFSettings->tfStartOrbit << " nHBF " << mTFSettings->nHBFPerTF << " runStartOrbit " << mTFSettings->runStartOrbit << " simStartOrbit " << mTFSettings->simStartOrbit;
}
ptrs.settingsTF = mTFSettings.get();

if (mConfParam->checkFirstTfOrbit) {
static uint32_t lastFirstTFOrbit = -1;
static uint32_t lastTFCounter = -1;
if (lastFirstTFOrbit != -1 && lastTFCounter != -1) {
int32_t diffOrbit = tinfo.firstTForbit - lastFirstTFOrbit;
int32_t diffCounter = tinfo.tfCounter - lastTFCounter;
if (diffOrbit != diffCounter * mTFSettings->nHBFPerTF) {
LOG(error) << "Time frame has mismatching firstTfOrbit - Last orbit/counter: " << lastFirstTFOrbit << " " << lastTFCounter << " - Current: " << tinfo.firstTForbit << " " << tinfo.tfCounter;
if (mSpecConfig.enableDoublePipeline != 2) {
if (mVerbosity) {
LOG(info) << "TF firstTForbit " << mTFSettings->tfStartOrbit << " nHBF " << mTFSettings->nHBFPerTF << " runStartOrbit " << mTFSettings->runStartOrbit << " simStartOrbit " << mTFSettings->simStartOrbit;
}
if (mConfParam->checkFirstTfOrbit) {
static uint32_t lastFirstTFOrbit = -1;
static uint32_t lastTFCounter = -1;
if (lastFirstTFOrbit != -1 && lastTFCounter != -1) {
int32_t diffOrbit = tinfo.firstTForbit - lastFirstTFOrbit;
int32_t diffCounter = tinfo.tfCounter - lastTFCounter;
if (diffOrbit != diffCounter * mTFSettings->nHBFPerTF) {
LOG(error) << "Time frame has mismatching firstTfOrbit - Last orbit/counter: " << lastFirstTFOrbit << " " << lastTFCounter << " - Current: " << tinfo.firstTForbit << " " << tinfo.tfCounter;
}
}
lastFirstTFOrbit = tinfo.firstTForbit;
lastTFCounter = tinfo.tfCounter;
}
lastFirstTFOrbit = tinfo.firstTForbit;
lastTFCounter = tinfo.tfCounter;
}

o2::globaltracking::RecoContainer inputTracksTRD;
Expand Down Expand Up @@ -1045,7 +1049,7 @@ void GPURecoWorkflowSpec::doCalibUpdates(o2::framework::ProcessingContext& pc, c
mGRPGeomUpdated = false;
needCalibUpdate = true;

if (!mITSGeometryCreated) {
if (mSpecConfig.runITSTracking && !mITSGeometryCreated) {
o2::its::GeometryTGeo* geom = o2::its::GeometryTGeo::Instance();
geom->fillMatrixCache(o2::math_utils::bit2Mask(o2::math_utils::TransformType::T2L, o2::math_utils::TransformType::T2GRot, o2::math_utils::TransformType::T2G));
mITSGeometryCreated = true;
Expand Down Expand Up @@ -1078,15 +1082,13 @@ void GPURecoWorkflowSpec::doCalibUpdates(o2::framework::ProcessingContext& pc, c
}
mMatLUTCreated = true;
}
if (!mTRDGeometryCreated) {
if (mSpecConfig.readTRDtracklets) {
auto gm = o2::trd::Geometry::instance();
gm->createPadPlaneArray();
gm->createClusterMatrixArray();
mTRDGeometry = std::make_unique<o2::trd::GeometryFlat>(*gm);
newCalibObjects.trdGeometry = mConfig->configCalib.trdGeometry = mTRDGeometry.get();
LOG(info) << "Loaded TRD geometry";
}
if (mSpecConfig.readTRDtracklets && !mTRDGeometryCreated) {
auto gm = o2::trd::Geometry::instance();
gm->createPadPlaneArray();
gm->createClusterMatrixArray();
mTRDGeometry = std::make_unique<o2::trd::GeometryFlat>(*gm);
newCalibObjects.trdGeometry = mConfig->configCalib.trdGeometry = mTRDGeometry.get();
LOG(info) << "Loaded TRD geometry";
mTRDGeometryCreated = true;
}
}
Expand Down Expand Up @@ -1144,12 +1146,12 @@ Inputs GPURecoWorkflowSpec::inputs()
} else if (mSpecConfig.enableDoublePipeline == 1) {
inputs.emplace_back("pipelineprepare", gDataOriginGPU, "PIPELINEPREPARE", 0, Lifetime::Timeframe);
}
if (mSpecConfig.outputTracks || mSpecConfig.caClusterer) {
if (mSpecConfig.enableDoublePipeline != 2 && (mSpecConfig.outputTracks || mSpecConfig.caClusterer)) {
// calibration objects for TPC clusterization
inputs.emplace_back("tpcgain", gDataOriginTPC, "PADGAINFULL", 0, Lifetime::Condition, ccdbParamSpec(o2::tpc::CDBTypeMap.at(o2::tpc::CDBType::CalPadGainFull)));
inputs.emplace_back("tpcaltrosync", gDataOriginTPC, "ALTROSYNCSIGNAL", 0, Lifetime::Condition, ccdbParamSpec(o2::tpc::CDBTypeMap.at(o2::tpc::CDBType::AltroSyncSignal)));
}
if (mSpecConfig.outputTracks) {
if (mSpecConfig.enableDoublePipeline != 2 && mSpecConfig.outputTracks) {
// calibration objects for TPC tracking
const auto mapSources = mSpecConfig.tpcDeadMapSources;
if (mapSources != 0) {
Expand Down Expand Up @@ -1219,15 +1221,17 @@ Inputs GPURecoWorkflowSpec::inputs()
} else if (mSpecConfig.itsTriggerType == 2) {
inputs.emplace_back("phystrig", "TRD", "TRKTRGRD", 0, Lifetime::Timeframe);
}
if (mSpecConfig.isITS3) {
inputs.emplace_back("cldict", "IT3", "CLUSDICT", 0, Lifetime::Condition, ccdbParamSpec("IT3/Calib/ClusterDictionary"));
inputs.emplace_back("alppar", "ITS", "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec("ITS/Config/AlpideParam"));
} else {
inputs.emplace_back("itscldict", "ITS", "CLUSDICT", 0, Lifetime::Condition, ccdbParamSpec("ITS/Calib/ClusterDictionary"));
inputs.emplace_back("itsalppar", "ITS", "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec("ITS/Config/AlpideParam"));
}
if (mSpecConfig.itsOverrBeamEst) {
inputs.emplace_back("meanvtx", "GLO", "MEANVERTEX", 0, Lifetime::Condition, ccdbParamSpec("GLO/Calib/MeanVertex", {}, 1));
if (mSpecConfig.enableDoublePipeline != 2) {
if (mSpecConfig.isITS3) {
inputs.emplace_back("cldict", "IT3", "CLUSDICT", 0, Lifetime::Condition, ccdbParamSpec("IT3/Calib/ClusterDictionary"));
inputs.emplace_back("alppar", "ITS", "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec("ITS/Config/AlpideParam"));
} else {
inputs.emplace_back("itscldict", "ITS", "CLUSDICT", 0, Lifetime::Condition, ccdbParamSpec("ITS/Calib/ClusterDictionary"));
inputs.emplace_back("itsalppar", "ITS", "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec("ITS/Config/AlpideParam"));
}
if (mSpecConfig.itsOverrBeamEst) {
inputs.emplace_back("meanvtx", "GLO", "MEANVERTEX", 0, Lifetime::Condition, ccdbParamSpec("GLO/Calib/MeanVertex", {}, 1));
}
}
if (mSpecConfig.processMC) {
inputs.emplace_back("itsmclabels", "ITS", "CLUSTERSMCTR", 0, Lifetime::Timeframe);
Expand Down