-
Notifications
You must be signed in to change notification settings - Fork 483
DPL Analysis: rework cursor logic keeping the gsl::span for VLAs
#14607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Looks good. Shall I test it on hyperloop? |
|
Let's wait for the rest of CI to complete, the issues in the previous version were specifically with o2_slc9 |
|
@ktf this time it was all-green in CI. I've committed the suggested change and now it is ready for testing on Hyperloop. |
|
Tested on hyperloop (Correlations, histograms). No regressions spotted. |
|
I think in the ASoA.h we still have: gsl::span<const _Type_> inline getIds() const \
{ \
return _Getter_##Ids(); \
} \
\
gsl::span<const _Type_> _Getter_##Ids() const \
{ \
return *mColumnIterator; \
} Which results in table converters when trying to fill values of the old table into the new table in errors, because the new table is expecting |
Replace
gsl::spanwithstd::spanalmost everywhere.Make sure the cursor table fill can accept span.