Skip to content

Conversation

@shahor02
Copy link
Collaborator

This reverts commit 7262c36. The correction of #14589 was actually not needed, just the name of the method is misleading.

At least the

const int idChamber = mGeom->getDetectorSec(cIdChamber);
if (idChamber < 0 || idChamber > 29) {
LOG(fatal) << "Chamber ID out of bounds";
}
uses this method to get detector ID within the sector rather than the sector ID.

This reverts commit 7262c36.
The correction of AliceO2Group#14589
was actually not needed, just the name of the method is misleading.
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@shahor02 shahor02 marked this pull request as ready for review August 18, 2025 14:30
@shahor02
Copy link
Collaborator Author

Merging as the previous correction was wrong and may create problems.

@shahor02 shahor02 merged commit fa7d8f9 into AliceO2Group:dev Aug 18, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant